https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/89509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -90,8 +91,9 @@ RewriteRuleWith StringviewNullptrCheckImpl() {
auto HandleTemporaryCXXTemporaryObjectExprAndCompoundLiteralExpr = makeRule(
cxxTemporaryObjectExpr(cxxConstructExpr(
HasBasicStringViewType, argumentCountIs(1),
- hasAnyArgument(/* `has
@@ -74,8 +74,9 @@ RewriteRuleWith StringviewNullptrCheckImpl() {
auto BasicStringViewConstructingFromNullExpr =
cxxConstructExpr(
HasBasicStringViewType, argumentCountIs(1),
- hasAnyArgument(/* `hasArgument` would skip over parens */ anyOf(
-
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/89509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti requested changes to this pull request.
I started taking a look at this and realized you switched up which argument
matcher needs the extra `ignoringParenImpCasts`, so that it can be removed from
the matcher definition.
See
https://github.com/llvm/llvm-project/blob
komalverma04 wrote:
@PiotrZSL Please guide me tackling the failing tests
https://github.com/llvm/llvm-project/pull/89509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: None (komalverma04)
Changes
# Maintaining Consistency in `hasAnyArgument()` and `hasArgument()` Matchers in
Clang AST Matchers
The `hasArgument()` matcher already ignores implicit casts and parentheses, but
the `hasAnyArgument()` ma
https://github.com/komalverma04 created
https://github.com/llvm/llvm-project/pull/89509
# Maintaining Consistency in `hasAnyArgument()` and `hasArgument()` Matchers in
Clang AST Matchers
The `hasArgument()` matcher already ignores implicit casts and parentheses, but
the `hasAnyArgument()` mat
