@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
+
+license
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
+
+license
@@ -0,0 +1,46 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(features = ["layering_check"],
MaskRay
@@ -18,7 +18,6 @@
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H
#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H
-#include "Feature.h"
MaskRay wrote:
This change should be removed.
https://github.com/llvm/llvm-project/pull/81556
https://github.com/MaskRay approved this pull request.
bazel-specific changes often have a title `[bazel] Add clangd support`. Please
consider following suit.
It would be nice to have a fuller support, but I understand having this
cc_library first can make your downstream changes easier, so LG
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> Ping!
llvm-project email notifications are extremely high-volume and nobody can
notice every change even if they are subscribed to the relevant labels...
If you don't have write/triage role
(https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-r
https://github.com/josh11b updated
https://github.com/llvm/llvm-project/pull/81556
>From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001
From: Josh L
Date: Mon, 12 Feb 2024 22:59:21 +
Subject: [PATCH 1/2] Add bazel support for clangd as a library.
---
clang-tools-extra/c
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
--
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
+
+license
https://github.com/josh11b updated
https://github.com/llvm/llvm-project/pull/81556
>From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001
From: Josh L
Date: Mon, 12 Feb 2024 22:59:21 +
Subject: [PATCH 1/2] Add bazel support for clangd as a library.
---
clang-tools-extra/c
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
+
+license
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
--
josh11b wrote:
Ping!
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
josh11b wrote:
Ping!
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
josh11b wrote:
I've made my email address public, as requested.
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/josh11b updated
https://github.com/llvm/llvm-project/pull/81556
>From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001
From: Josh L
Date: Mon, 12 Feb 2024 22:59:21 +
Subject: [PATCH] Add bazel support for clangd as a library.
---
clang-tools-extra/clang
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo.
Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account.
See [LLVM
Discourse](https://discourse.llvm.org/t/hidden-em
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: None (josh11b)
Changes
Both creates a `BUILD.bazel` file for the `clangd` directory in the project
overlay, and removes an unnecessary `#include "Feature.h"` to reduce the
dependencies from `Transport.h`.
This upstreams the patch that a
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/josh11b created
https://github.com/llvm/llvm-project/pull/81556
Both creates a `BUILD.bazel` file for the `clangd` directory in the project
overlay, and removes an unnecessary `#include "Feature.h"` to reduce the
dependencies from `Transport.h`.
This upstreams the patch tha
21 matches
Mail list logo
