ilovepi wrote:
@PeterChou1 I've uploaded a patch set w/ the relevant changes from this patch.
Some of the details were split into standalone patches, but I'd appreciate if
you could help both review and test those patches. It would also be nice if you
could share any testing corpus or lit test
ilovepi wrote:
OK. I'll put up a patch set around Tuesday, April 22.
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
FYI the new GSOC period is going to start around May 8. We hope to have new
students working on clang-doc, so this patch series needs to be landed by then
so we don't have students blocked on this. While there has been some progress
on the patch set, its been up in one form or a
PeterChou1 wrote:
> Any progress, @PeterChou1 ?
Sorry for the delay, I am currently trying to fix the bugs associated with this
branch, I should have something ready for review by tomorrow
https://github.com/llvm/llvm-project/pull/133161
___
cfe-comm
ilovepi wrote:
@PeterChou1 when you split this up, please include me, @petrhosek, and
@mysterymath.
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -0,0 +1,104 @@
+//===- mustache.cpp - The LLVM Modular Optimizer
ilovepi wrote:
Can you remove this since you have a separate PR for it?
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
@@ -26,5 +26,3 @@ class Shape {
*/
virtual double perimeter() const = 0;
};
-
-
ilovepi wrote:
unrelated
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@lists.llvm.
@@ -0,0 +1,227 @@
+{{!
+Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+See https://llvm.org/LICENSE.txt for license information.
+SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+This file defines the template for cla
@@ -0,0 +1,47 @@
+{{!
+Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+See https://llvm.org/LICENSE.txt for license information.
+SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+This file defines the template for gene
@@ -209,6 +215,7 @@ struct FieldTypeInfo : public TypeInfo {
return std::tie(Type, Name, DefaultValue) ==
std::tie(Other.Type, Other.Name, Other.DefaultValue);
}
+
ilovepi wrote:
remove
https://github.com/llvm/llvm-project/pull/133161
_
@@ -161,8 +164,11 @@ struct TypeInfo {
: Type(SymbolID(), Name, InfoType::IT_default, Name, Path) {}
bool operator==(const TypeInfo &Other) const { return Type == Other.Type; }
-
+
ilovepi wrote:
nit: whitespace on empty line.
https://github.com/ll
@@ -455,8 +473,9 @@ struct EnumValueInfo {
// Stores the user-supplied initialization expression for this enumeration
// constant. This will be empty for implicit enumeration values.
SmallString<16> ValueExpr;
-
- std::vector Description; /// Comment description of this
@@ -32,6 +33,183 @@ populateParentNamespaces(llvm::SmallVector
&Namespaces,
static void populateMemberTypeInfo(MemberTypeInfo &I, const FieldDecl *D);
+void getTemplateParameters(const TemplateParameterList *TemplateParams,
+ llvm::raw_ostream &Str
@@ -0,0 +1,75 @@
+//===-- FileHelpersClangDoc.cpp - File Helpers ---*-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,26 @@
+//===-- FileHelpersClangDoc.h --- File Helpers ---*-
C++-*-===//
ilovepi wrote:
probably putting this in `clang-doc/support/File.h` is a bit more typical. At
the least the file shouldn't have helper in the name, and probably do
@@ -32,6 +33,183 @@ populateParentNamespaces(llvm::SmallVector
&Namespaces,
static void populateMemberTypeInfo(MemberTypeInfo &I, const FieldDecl *D);
+void getTemplateParameters(const TemplateParameterList *TemplateParams,
+ llvm::raw_ostream &Str
@@ -412,12 +427,15 @@ struct TypedefInfo : public SymbolInfo {
void merge(TypedefInfo &&I);
TypeInfo Underlying;
-
- // Inidicates if this is a new C++ "using"-style typedef:
+ // Underlying type declaration
+ SmallString<16> TypeDeclaration;
+ // Indicates if this is
@@ -521,8 +540,9 @@ struct ClangDocContext {
// Path of CSS stylesheets that will be copied to OutDirectory and used to
// style all HTML files.
std::vector UserStylesheets;
- // JavaScript files that will be imported in all HTML files.
ilovepi wrote:
I
@@ -152,7 +153,9 @@ struct ScopeChildren {
// A base struct for TypeInfos
struct TypeInfo {
+
ilovepi wrote:
unnecessary
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@l
@@ -0,0 +1,523 @@
+//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -379,7 +394,7 @@ struct RecordInfo : public SymbolInfo {
// Full qualified name of this record, including namespaces and template
// specializations.
SmallString<16> FullName;
-
+
ilovepi wrote:
nit: empty space. the newline is fine though.
https:/
@@ -359,6 +371,9 @@ struct FunctionInfo : public SymbolInfo {
// Full qualified name of this function, including namespaces and template
// specializations.
SmallString<16> FullName;
+
+ // Function Prototype
+ SmallString<256> ProtoType;
ilovepi wrot
https://github.com/ilovepi commented:
I know you're planing to split this up, but here's some preliminary feedback.
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -32,6 +33,183 @@ populateParentNamespaces(llvm::SmallVector
&Namespaces,
static void populateMemberTypeInfo(MemberTypeInfo &I, const FieldDecl *D);
+void getTemplateParameters(const TemplateParameterList *TemplateParams,
+ llvm::raw_ostream &Str
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/133161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
26 matches
Mail list logo
