aengelke wrote:
> What I feel the right initial question is, is this check actually making a
> significant difference to performance in real-world use cases?
raw_ostream::write shows up in my (downstream application) profiles at ~0.6%,
mostly through raw_svector_ostream, which is always unbuff
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/97396
>From 04b794a8a02f06803f96c40de042b13fd4b12c5f Mon Sep 17 00:00:00 2001
From: Alexis Engelke
Date: Mon, 1 Jul 2024 16:50:44 +0200
Subject: [PATCH 1/2] [Support] Remove raw_ostream::tie
Originally, tie was intro
jh7370 wrote:
> What was the motivation to keep this in llvm-dwarfdump?
If warnings or errors are printed by llvm-dwarfdump without this, we end up
with corrupted output, where stderr and stdout are intermixed in a
semi-arbitrary way. It was a while back that I made the original change mind
y
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-llvm-support
@llvm/pr-subscribers-clang-tools-extra
Author: Alexis Engelke (aengelke)
Changes
Originally, tie was introduced by D81156 to flush stdout before writing to
stderr. 030897523 reverted this due to race condition
https://github.com/aengelke created
https://github.com/llvm/llvm-project/pull/97396
Originally, tie was introduced by D81156 to flush stdout before writing to
stderr. 030897523 reverted this due to race conditions. Nonetheless, it does
cost performance, causing an extra check in the "cold" pat
