[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf sivachandra wrote: I think it was removed because it is listed on line 130 also. https://g

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -9,15 +9,57 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H +#include "src/__support/File/file.h" #include "src/__support/arg_list.h" +#include "src/stdio/scanf_core/reader.h" +#include "src/stdio/scanf

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -220,6 +220,20 @@ add_libc_test( libc.src.stdio.vprintf ) + +if(LLVM_LIBC_FULL_BUILD) + # In fullbuild mode, fscanf's tests use the internal FILE for other functions. + list(APPEND fscanf_test_deps + libc.src.stdio.fclose + libc.src.stdio.ferror + l

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra commented: Few nits, but otherwise OK. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra edited https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -9,15 +9,57 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H +#include "src/__support/File/file.h" #include "src/__support/arg_list.h" +#include "src/stdio/scanf_core/reader.h" +#include "src/stdio/scanf

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/jhuber6 commented: The changes make sense to me overall with some nits. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -9,44 +9,61 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H -#include "src/stdio/scanf_core/file_reader.h" -#include "src/stdio/scanf_core/string_reader.h" +#include "src/__support/macros/attributes.h" // For LIBC_INLINE #

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -126,6 +126,10 @@ set(TARGET_LIBC_ENTRYPOINTS libc.src.stdio.snprintf libc.src.stdio.vsprintf libc.src.stdio.vsnprintf +#TODO: Check if scanf can be enabled on aarch64 jhuber6 wrote: Seems like this should be tested first. https://github.co

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf jhuber6 wrote: Does this accidentally delete `printf`? https://github.com/llvm/llvm-projec