schenka0 wrote:
> (I'm not sure how that happened in the first place.)
I believe you suggested a (minor) change and I just clicked commit suggestion:
Didn't realize
HighCommander4 wrote:
> (A drive-by comment: I stumbled on the commit message of this PR and found it
> surprising that I'm the co-author of it! I'm not entirely clear on GitHub's
> schemas, but IMO shouldn't the co-author be the one who clicks the "merge"
> button?)
The reason is that one of
zyn0217 wrote:
(A drive-by comment: I stumbled on the commit message of this PR and found it
surprising that I'm the co-author of it! I'm not entirely clear on GitHub's
schemas, but IMO shouldn't the co-author be the one who clicks the "merge"
button?)
https://github.com/llvm/llvm-project/pul
HighCommander4 wrote:
> @HighCommander4 Thanks for the review. I've updated the comments, but don't
> have merge access, could you merge this? Thanks
Done
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
schenka0 wrote:
@HighCommander4 Thanks for the review. I've updated the comments, but don't
have merge access, could you merge this? Thanks
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/schenka0 updated
https://github.com/llvm/llvm-project/pull/76668
>From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001
From: schenka0 <154034018+schen...@users.noreply.github.com>
Date: Mon, 1 Jan 2024 01:31:05 -0500
Subject: [PATCH 1/4] Check for invalid SLo
@@ -813,6 +813,18 @@ TEST(SourceCodeTests, isKeywords) {
EXPECT_FALSE(isKeyword("override", LangOpts));
}
+TEST(SourceCodeTests, isSpelledInSource) {
+ Annotations Test("");
+ ParsedAST AST = TestTU::withCode(Test.code()).build();
+ const SourceManager &SM = AST.getSource
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 approved this pull request.
Thanks, looks good with the added comments.
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
schenka0 wrote:
I struggled to rebase my changes around some merges and accidently included
additional changes at one point which triggered the llvmbot to add extra tags.
Sorry!
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing
@@ -813,6 +813,21 @@ TEST(SourceCodeTests, isKeywords) {
EXPECT_FALSE(isKeyword("override", LangOpts));
}
+TEST(SourceCodeTests, isSpelledInSource) {
+ Annotations Test(R"cpp(
+int abc = 1;
+)cpp");
+
+ ParsedAST AST = TestTU::withCode(Test.code()).build();
+
https://github.com/schenka0 updated
https://github.com/llvm/llvm-project/pull/76668
>From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001
From: schenka0 <154034018+schen...@users.noreply.github.com>
Date: Mon, 1 Jan 2024 01:31:05 -0500
Subject: [PATCH 1/3] Check for invalid SLo
https://github.com/schenka0 updated
https://github.com/llvm/llvm-project/pull/76668
>From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001
From: schenka0 <154034018+schen...@users.noreply.github.com>
Date: Mon, 1 Jan 2024 01:31:05 -0500
Subject: [PATCH 1/2] Check for invalid SLo
https://github.com/schenka0 updated
https://github.com/llvm/llvm-project/pull/76668
>From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001
From: schenka0 <154034018+schen...@users.noreply.github.com>
Date: Mon, 1 Jan 2024 01:31:05 -0500
Subject: [PATCH] Check for invalid SLocEnt
@@ -232,7 +232,12 @@ bool isSpelledInSource(SourceLocation Loc, const
SourceManager &SM) {
if (Loc.isFileID())
return true;
auto Spelling = SM.getDecomposedSpellingLoc(Loc);
- StringRef SpellingFile = SM.getSLocEntry(Spelling.first).getFile().getName();
+ bool Invali
@@ -232,7 +232,12 @@ bool isSpelledInSource(SourceLocation Loc, const
SourceManager &SM) {
if (Loc.isFileID())
return true;
auto Spelling = SM.getDecomposedSpellingLoc(Loc);
- StringRef SpellingFile = SM.getSLocEntry(Spelling.first).getFile().getName();
+ bool Invali
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/schenka0 updated
https://github.com/llvm/llvm-project/pull/76668
>From c9e2b9ad57aa9bac52324c91fe6d4ec1aa39ff41 Mon Sep 17 00:00:00 2001
From: schenka0 <154034018+schen...@users.noreply.github.com>
Date: Mon, 1 Jan 2024 01:31:05 -0500
Subject: [PATCH 1/2] Check for invalid SLo
schenka0 wrote:
PR: @sam-mccall
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/schenka0 edited
https://github.com/llvm/llvm-project/pull/76668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
22 matches
Mail list logo
