https://github.com/AlanRosenthal updated
https://github.com/llvm/llvm-project/pull/104868
>From 5f84cc47cde13732ed61eccc0b17f6c420a64ab7 Mon Sep 17 00:00:00 2001
From: Alan Rosenthal
Date: Thu, 22 Aug 2024 21:42:04 +
Subject: [PATCH 1/3] [clang-tidy] Update TODO comment check
The doc for g
https://github.com/AlanRosenthal updated
https://github.com/llvm/llvm-project/pull/104868
>From 5f84cc47cde13732ed61eccc0b17f6c420a64ab7 Mon Sep 17 00:00:00 2001
From: Alan Rosenthal
Date: Thu, 22 Aug 2024 21:42:04 +
Subject: [PATCH 1/2] [clang-tidy] Update TODO comment check
The doc for g
@@ -24,3 +24,7 @@
// TODO(b/12345): find the holy grail
// TODO (b/12345): allow spaces before parentheses
// TODO(asdf) allow missing semicolon
+// TODO: bug 12345678 - Remove this after the 2047q4 compatibility window
expires.
+// TODO: example.com/my-design-doc - Manually f
@@ -9,6 +9,7 @@
#include "TodoCommentCheck.h"
#include "clang/Frontend/CompilerInstance.h"
#include "clang/Lex/Preprocessor.h"
+#include
5chmidti wrote:
Please remove this unused include
https://github.com/llvm/llvm-project/pull/104868
__
@@ -24,3 +24,7 @@
// TODO(b/12345): find the holy grail
// TODO (b/12345): allow spaces before parentheses
// TODO(asdf) allow missing semicolon
+// TODO: bug 12345678 - Remove this after the 2047q4 compatibility window
expires.
+// TODO: example.com/my-design-doc - Manually f
@@ -45,7 +54,7 @@ class TodoCommentCheck::TodoCommentHandler : public
CommentHandler {
private:
TodoCommentCheck &Check;
std::string User;
- llvm::Regex TodoMatch;
+ std::list TodoMatches;
AlanRosenthal wrote:
Hi @njames93, thanks for the review. I've u
https://github.com/AlanRosenthal updated
https://github.com/llvm/llvm-project/pull/104868
>From 5f84cc47cde13732ed61eccc0b17f6c420a64ab7 Mon Sep 17 00:00:00 2001
From: Alan Rosenthal
Date: Thu, 22 Aug 2024 21:42:04 +
Subject: [PATCH] [clang-tidy] Update TODO comment check
The doc for googl
https://github.com/njames93 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/104868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlanRosenthal updated
https://github.com/llvm/llvm-project/pull/104868
>From 9415bc98324a6715a77704acab58b53922297402 Mon Sep 17 00:00:00 2001
From: Alan Rosenthal
Date: Mon, 19 Aug 2024 22:56:29 +
Subject: [PATCH] [clang-tidy] Update TODO comment check
The doc for googl
https://github.com/AlanRosenthal updated
https://github.com/llvm/llvm-project/pull/104868
>From 891fe7098179188bea3bd825f615762022cb0828 Mon Sep 17 00:00:00 2001
From: Alan Rosenthal
Date: Mon, 19 Aug 2024 22:44:30 +
Subject: [PATCH] [clang-tidy] Update TODO comment check
The doc for googl
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Alan Rosenthal (AlanRosenthal)
Changes
The doc for google-readability-todo reference lists two styles of TODO comments:
https://google.github.io/styleguide/cppguide.html#TODO_Comments
Previously,
https://github.com/AlanRosenthal created
https://github.com/llvm/llvm-project/pull/104868
The doc for google-readability-todo reference lists two styles of TODO comments:
https://google.github.io/styleguide/cppguide.html#TODO_Comments
Previously, only `TODO(info): comment` were supported.
After
12 matches
Mail list logo
