https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/88268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
revane wrote:
@AaronBallman I can't land this PR.
https://github.com/llvm/llvm-project/pull/88268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
revane wrote:
I don't have write access. Would someone please land the PR for me?
https://github.com/llvm/llvm-project/pull/88268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
revane wrote:
@PiotrZSL @carlosgalvezp @LegalizeAdulthood @njames93 For your consideration.
https://github.com/llvm/llvm-project/pull/88268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Edwin Vane (revane)
Changes
Some functions allow a null SourceManager, no SourceManager, or a SourceManager
in an inconsistent argument position. Since SourceManager is generally not null
and it doesn't make sense to apply renaming w
https://github.com/revane created
https://github.com/llvm/llvm-project/pull/88268
Some functions allow a null SourceManager, no SourceManager, or a SourceManager
in an inconsistent argument position. Since SourceManager is generally not null
and it doesn't make sense to apply renaming without
