https://github.com/evelez7 closed
https://github.com/llvm/llvm-project/pull/145595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
evelez7 wrote:
### Merge activity
* **Jun 26, 5:09 PM UTC**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/145595).
https://github.com/llvm/llvm-project/pull/145595
https://github.com/petrhosek approved this pull request.
Looks great! One idea for future improvement would be to wrap
`std::optional RepositoryUrl` in a object (e.g.
`SerializationContext`) so in the future if we need to pass around more
information beside the URL, we don't need to modify eve
https://github.com/evelez7 updated
https://github.com/llvm/llvm-project/pull/145595
>From 19569ab7cecab1d2d0c608d85d7571dd9c754101 Mon Sep 17 00:00:00 2001
From: Erick Velez
Date: Tue, 24 Jun 2025 11:19:06 -0700
Subject: [PATCH] [clang-doc] refactor JSONGenerator array usage
Improve code reuse
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Erick Velez (evelez7)
Changes
Improve code reuse by calling serializeArray in more generic cases
instead of creating and reserving arrays on their own.
---
Full diff: https://github.com/llvm/llvm-project/pull/145595.diff
1 Fi
https://github.com/evelez7 ready_for_review
https://github.com/llvm/llvm-project/pull/145595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -454,27 +417,19 @@ static void serializeInfo(const RecordInfo &I,
json::Object &Obj,
Obj["ProtectedMembers"] = ProtectedMembersArray;
}
- if (!I.Bases.empty()) {
-json::Value BasesArray = Array();
-json::Array &BasesArrayRef = *BasesArray.getAsArray();
-
@@ -454,27 +417,19 @@ static void serializeInfo(const RecordInfo &I,
json::Object &Obj,
Obj["ProtectedMembers"] = ProtectedMembersArray;
}
- if (!I.Bases.empty()) {
-json::Value BasesArray = Array();
-json::Array &BasesArrayRef = *BasesArray.getAsArray();
-
@@ -278,6 +247,16 @@ static void serializeInfo(const ConstraintInfo &I, Object
&Obj) {
Obj["Expression"] = I.ConstraintExpr;
}
+static void serializeInfo(const std::vector &Params,
ilovepi wrote:
```suggestion
static void serializeInfo(ArrayRef Params,
```
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/145595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM. Glad to see so much code getting deleted! Overall great cleanups. Left a
couple small comments inline.
https://github.com/llvm/llvm-project/pull/145595
___
cfe-commits mailing list
cfe-commi
https://github.com/evelez7 updated
https://github.com/llvm/llvm-project/pull/145595
>From df4ddc4f8bdaaf7cf47865f2c9c98622ca4941fa Mon Sep 17 00:00:00 2001
From: Erick Velez
Date: Tue, 24 Jun 2025 11:19:06 -0700
Subject: [PATCH] [clang-doc] refactor JSONGenerator array usage
Improve code reuse
12 matches
Mail list logo
