[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

ilovepi wrote: any progress here? https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang-tools-extra/clang-doc/BitcodeReader.cpp clan

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -238,31 +238,32 @@ struct MemberTypeInfo : public FieldTypeInfo { }; struct Location { - Location(int LineNumber = 0, StringRef Filename = StringRef(), - bool IsFileInRootDir = false) - : LineNumber(LineNumber), Filename(Filename), -IsFileInRootDir(I

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -28,6 +28,18 @@ template bool isTypedefAnonRecord(const T *D) { return false; } +Location MapASTVisitor::getDeclLocation(const NamedDecl *D) const { + bool IsFileInRootDir; + llvm::SmallString<128> File = + getFile(D, D->getASTContext(), CDCtx.SourceRoot, IsFileIn

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -238,31 +238,32 @@ struct MemberTypeInfo : public FieldTypeInfo { }; struct Location { - Location(int LineNumber = 0, StringRef Filename = StringRef(), - bool IsFileInRootDir = false) - : LineNumber(LineNumber), Filename(Filename), -IsFileInRootDir(I

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/mysterymath approved this pull request. https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

ilovepi wrote: seems like some tests need to be updated w/ the new interface. https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -135,7 +135,7 @@ llvm::Error decodeRecord(const Record &R, if (R[0] > INT_MAX) return llvm::createStringError(llvm::inconvertibleErrorCode(), "integer too large to parse"); - Field.emplace_back((int)R[0], Blob, (bool)R[1]); + Field.

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -85,7 +85,7 @@ llvm::Error decodeRecord(const Record &R, std::optional &Field, if (R[0] > INT_MAX) return llvm::createStringError(llvm::inconvertibleErrorCode(), "integer too large to parse"); - Field.emplace((int)R[0], Blob, (bool)

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -238,31 +238,32 @@ struct MemberTypeInfo : public FieldTypeInfo { }; struct Location { - Location(int LineNumber = 0, StringRef Filename = StringRef(), - bool IsFileInRootDir = false) - : LineNumber(LineNumber), Filename(Filename), -IsFileInRootDir(I

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/ilovepi approved this pull request. Mostly good, modulo a few small issues. https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

@@ -681,7 +675,7 @@ emitInfo(const RecordDecl *D, const FullComment *FC, int LineNumber, } // TODO: remove first call to parseBases, that function should be deleted parseBases(*I, C); -parseBases(*I, C, IsFileInRootDir, PublicOnly, true); +parseBases(*I, C,

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/135081 >From 8fb896f16396c2e01427ac7baa8791461ff500a3 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 3 Apr 2025 17:07:01 -0400 Subject: [PATCH 1/5] [clang-doc] add start and end line number --- clang-tools-e

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/135081 >From 8fb896f16396c2e01427ac7baa8791461ff500a3 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 3 Apr 2025 17:07:01 -0400 Subject: [PATCH 1/4] [clang-doc] add start and end line number --- clang-tools-e

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (PeterChou1) Changes Split from https://github.com/llvm/llvm-project/pull/133161 This patch adds start and end line numbers to clang-doc. Currently clang-doc only encodes the start line numbers of records, struct, etc. Th

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

https://github.com/PeterChou1 created https://github.com/llvm/llvm-project/pull/135081 Split from https://github.com/llvm/llvm-project/pull/133161 This patch adds start and end line numbers to clang-doc. Currently clang-doc only encodes the start line numbers of records, struct, etc. This patc