@@ -305,7 +305,7 @@ IncludeInserter::calculateIncludePath(const HeaderFile
&InsertedHeader,
if (llvm::sys::path::is_absolute(Suggested))
return std::nullopt;
bool IsAngled = false;
- for (auto Filter : AngledHeaders) {
+ for (auto &Filter : AngledHeaders) {
-
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Zahira Ammarguellat (zahiraam)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/134138.diff
3 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp (+1-1)
- (modified) clang
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Zahira Ammarguellat (zahiraam)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/134138.diff
3 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp (+1-1)
- (modi
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlosgalvezp approved this pull request.
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> In general, I don't fully understand the scope of this patch. Surely, there's
> thousands of things that could be improved in the codebase. Which of those
> belong to this patch? Reviewers can always point out things that could be
> improved ad infinitum, leading to a patch w
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
carlosgalvezp wrote:
In general, I don't fully understand the scope of this patch. Surely, there's
thousands of things that could be improved in the codebase. Which of those
belong to this patch? Reviewers can always point out things that could be
improved ad infinitum, leading to a patch with
@@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
-auto Filter = [Filters](llvm::StringRef Path) {
+auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
nicovank wrote:
Line 520: th
@@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
-auto Filter = [Filters](llvm::StringRef Path) {
+auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
for (auto &Regex : *Filters)
--
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/4] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
zahiraam wrote:
> The changes to the clang-tidy check should be reverted IMO.
>
> Also, please provide more information. What do you mean by "code sanitizer",
> what is the exact error message, etc.
Please see above the error message from sanitizer. I can revert the change if
you think the do
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/3] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
https://github.com/carlosgalvezp requested changes to this pull request.
The changes to the clang-tidy check should be reverted IMO.
Also, please provide more information. What do you mean by "code sanitizer",
what is the exact error message, etc.
https://github.com/llvm/llvm-project/pull/1341
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Zahira Ammarguellat (zahiraam)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/134138.diff
3 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp (+1-1)
- (modified) c
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/2] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
24 matches
Mail list logo
