https://github.com/sthibaul closed
https://github.com/llvm/llvm-project/pull/78520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DamonFool wrote:
> Is there a reason you put this first? Otherwise IMO it is slightly neater to
> put it last.
This bug had been fixed here:
```
commit 1b60ddd920e0caadfa85cc7013b559d6453d7e3e
Author: Jie Fu
Date: Thu Jan 18 07:34:09 2024 +0800
[Hurd] Fix -Wswitch in Hurd::getDynamicLi
sthibaul wrote:
> Is there a reason you put this first?
No particular reason.
> Otherwise IMO it is slightly neater to put it last.
Done so.
https://github.com/llvm/llvm-project/pull/78520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/sthibaul updated
https://github.com/llvm/llvm-project/pull/78520
>From 15e157e3f7a6beb0b8be36ad1a9dbe3d2079eecf Mon Sep 17 00:00:00 2001
From: Samuel Thibault
Date: Thu, 18 Jan 2024 00:18:03 +0100
Subject: [PATCH] hurd: Fix build with -Werror,-Wswitch
We do not handle all ar
https://github.com/fmayer approved this pull request.
Is there a reason you put this first? Otherwise IMO it is slightly neater to
put it last.
https://github.com/llvm/llvm-project/pull/78520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
sthibaul wrote:
> Drive-by: is the `llvm_unreachable` actually unreachable? I.e. we never call
> this function with this case?
Hurd triplets are only defined for x86 and x86_64.
https://github.com/llvm/llvm-project/pull/78520
___
cfe-commits mailing
fmayer wrote:
Drive-by: is the `llvm_unreachable` actually unreachable? I.e. we never call
this function with this case? Otherwise we are introducing UB in `NDEBUG` builds
```
/// In NDEBUG builds, if the platform does not support a builtin unreachable
/// then we call an internal LLVM runtime
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Samuel Thibault (sthibaul)
Changes
We do not handle all architectures, llvm_unreachable is called after the
switch, so we can just break.
Fixes https://lab.llvm.org/buildbot/#/builders/19/builds/23702
---
Full diff: https://github.com/ll
https://github.com/sthibaul created
https://github.com/llvm/llvm-project/pull/78520
We do not handle all architectures, llvm_unreachable is called after the
switch, so we can just break.
Fixes https://lab.llvm.org/buildbot/#/builders/19/builds/23702
>From 682392edc899cdae19e73548feaf118e137e1
