On Tue, Jun 16, 2020 at 8:17 AM Kristóf Umann wrote:
>
> Apologies for the inconvenience, though I wonder why I haven't gotten
> builtbot mails :/
>
> On Tue, 16 Jun 2020 at 09:54, Haojian Wu wrote:
>>
>> On Mon, 15 Jun 2020 at 18:29, David Blaikie wrote:
>>>
>>> I don't think the comment's add
Apologies for the inconvenience, though I wonder why I haven't gotten
builtbot mails :/
On Tue, 16 Jun 2020 at 09:54, Haojian Wu wrote:
> On Mon, 15 Jun 2020 at 18:29, David Blaikie wrote:
>
>> I don't think the comment's adding value here - it should be fairly
>> clear from the context that th
On Mon, 15 Jun 2020 at 18:29, David Blaikie wrote:
> I don't think the comment's adding value here - it should be fairly
> clear from the context that the whole loop only exists for some
> assertions.
>
> Also: Could you remove the "(void)" casts now that the whole thing's
> wrapped in NDEBUG?
>
I don't think the comment's adding value here - it should be fairly
clear from the context that the whole loop only exists for some
assertions.
Also: Could you remove the "(void)" casts now that the whole thing's
wrapped in NDEBUG?
(an alternative way of phrasing this that doesn't require the #if
Author: Haojian Wu
Date: 2020-06-12T15:42:29+02:00
New Revision: e4b3fc18d33199e2081d300f14687d81be48b6a0
URL:
https://github.com/llvm/llvm-project/commit/e4b3fc18d33199e2081d300f14687d81be48b6a0
DIFF:
https://github.com/llvm/llvm-project/commit/e4b3fc18d33199e2081d300f14687d81be48b6a0.diff
LO
