[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { AustinSchuh wrote: I tried that round 1 of this review, and it went quite poorly: https://b

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { AustinSchuh wrote: OK, newest patch should do what you suggested, thanks for the help! https

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/134758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

https://github.com/AustinSchuh updated https://github.com/llvm/llvm-project/pull/134758 >From 1e6367407a4b23b2a85f088ba4b66a0c0afc8faa Mon Sep 17 00:00:00 2001 From: Austin Schuh Date: Mon, 7 Apr 2025 17:18:38 -0700 Subject: [PATCH 1/2] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA Sig

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

https://github.com/AustinSchuh updated https://github.com/llvm/llvm-project/pull/134758 >From 1e6367407a4b23b2a85f088ba4b66a0c0afc8faa Mon Sep 17 00:00:00 2001 From: Austin Schuh Date: Mon, 7 Apr 2025 17:18:38 -0700 Subject: [PATCH 1/2] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA Sig

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

https://github.com/Artem-B approved this pull request. LGTM. Thank you! https://github.com/llvm/llvm-project/pull/134758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { AustinSchuh wrote: That is super helpful, thanks! I'll get back to you soon https://github.

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { Artem-B wrote: See above. propagate-attributes.cu just needs to apply `extern "C"` to the fu

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { AustinSchuh wrote: Some of it was around one of the tests trying to include cuda.h inside an

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { Artem-B wrote: Those are actually *useful* failures and expose real issues in those tests. -

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

@@ -2,6 +2,170 @@ // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s #include "Inputs/cuda.h" +struct char1 { Artem-B wrote: These type declarations should go into Inputs/cuda.h https://github.com/llvm/

[clang] cuda clang: Move nvptx-surface.cu test to CodeGenCUDA (PR #134758)

https://github.com/Artem-B requested changes to this pull request. Hold on a sec. https://github.com/llvm/llvm-project/pull/134758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits