[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-14 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Sean Perry via cfe-commits
https://github.com/perry-ca approved this pull request. This works on z/OS. Thanks for fixing it. https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: Window bot passed, which was the important bit. Linux failed on a different test entirely https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: > @arsenm what are you actually trying to fix and what do you expect this to do? Fix not running tests except on linux. We should have maximum host test coverage, and this test has no reason to depend on the host. All it needs is the explicit target instead of relying on the defa

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Alex Voicu via cfe-commits
AlexVlx wrote: @arsenm what are you actually trying to fix and what do you expect this to do? https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
@@ -1,21 +1,17 @@ -// REQUIRES: x86-registered-target -// REQUIRES: amdgpu-registered-target -// REQUIRES: system-linux arsenm wrote: This is a pile of workarounds, there's no reason any of these tests should be host dependent https://github.com/llvm/llvm-proj

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Shilei Tian via cfe-commits
@@ -1,21 +1,17 @@ -// REQUIRES: x86-registered-target -// REQUIRES: amdgpu-registered-target -// REQUIRES: system-linux shiltian wrote: I'm not sure if the removal of `system-linux` would cause issue. https://github.com/llvm/llvm-project/pull/111975

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Matt Arsenault (arsenm) Changes Use explicit target and stop restricting hosts it can run on. --- Full diff: https://github.com/llvm/llvm-project/pull/111975.diff 1 Files Affected: - (modified) clang/test/Driver/hipstdpar.c (+6-1

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: * **#111976** https://app.graphite.dev/github/pr/llvm/llvm-project/111976?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> * **#111975** https://app.graphite.dev/github/pr/llvm/llvm-p

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/111975 Use explicit target and stop restricting hosts it can run on. >From d3ec46ab6c4d4d5d740336a9c81c24ed8dc70680 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Fri, 11 Oct 2024 14:38:02 +0400 Subject: [PATCH] c