https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xgupta wrote:
I have the access.
https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tru wrote:
Yep. Want me to do it or do you have access now?
https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xgupta wrote:
@tru Is it fine to commit this?
https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lxbndr wrote:
@tru I apologize for any inconvenience, but should I rebase this to the latest
master, or something else to unblock landing? I am not sure if I see any
suitable rule in the contribution guide. Just in case it occasionally turns out
that the blocker is me.
https://github.com/llvm
https://github.com/tru approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lxbndr wrote:
A short summary of changes:
- added link to the issue
- narrowed checks to aim cl.exe only (clang-cl.exe doesn't need this)
- changed approach a bit. Now we're looking for /O2 and /O1 flags in the
general flag set for the current configuration. Last effective found flag is
suppres
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
MSVC has a major performance regression observed when targeting ARM64 since
v19.32 (VS 17.2.0). `cl.exe` spends a lot of time on compiling
`StandardLibrary.cpp` and `CGBuiltin.cpp`, and total build duration rises
extremely. This makes bui
https://github.com/lxbndr updated
https://github.com/llvm/llvm-project/pull/65215
>From c97d9a28ef8cdb232670a960a46bc30b269983f7 Mon Sep 17 00:00:00 2001
From: Alexander Smarus
Date: Tue, 19 Sep 2023 00:34:54 +0300
Subject: [PATCH] Workaround for MSVC ARM64 build performance regression
---
cl
tru wrote:
I suspect maybe the MSVC_VERSION check might exclude clang-cl, but we should
make sure, because @omjavaid is correct, we shouldn't apply this to clang-cl
unless it shows the same problems.
https://github.com/llvm/llvm-project/pull/65215
__
omjavaid wrote:
Hi Have you compared build performance between cl and clang-cl? If only cl.exe
is taking a lot of time while clang-cl doesnt then may be we should make this
change specific to cl.exe.
https://github.com/llvm/llvm-project/pull/65215
__
@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS
TransformUtils
)
+# Workaround for MSVC ARM64 performance regression: disable all optimizations
(/Od)
+# and then enable back all /O2 options except one.
+if(NOT CMAKE_BUILD_TYPE MATCHES Debug
+AND MSVC
+AND MSVC_VERSI
@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS
TransformUtils
)
+# Workaround for MSVC ARM64 performance regression: disable all optimizations
(/Od)
lxbndr wrote:
I was not sure if the link is acceptable to mention there. Will do, thanks!
https://github.co
@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS
TransformUtils
)
+# Workaround for MSVC ARM64 performance regression: disable all optimizations
(/Od)
+# and then enable back all /O2 options except one.
+if(NOT CMAKE_BUILD_TYPE MATCHES Debug
+AND MSVC
+AND MSVC_VERSI
https://github.com/tru labeled https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tru labeled https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS
TransformUtils
)
+# Workaround for MSVC ARM64 performance regression: disable all optimizations
(/Od)
tru wrote:
I think this comment also should link to the issue on the Microsoft side so
that we can know to
https://github.com/tru review_requested
https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -30,6 +30,15 @@ set(LLVM_LINK_COMPONENTS
TransformUtils
)
+# Workaround for MSVC ARM64 performance regression: disable all optimizations
(/Od)
+# and then enable back all /O2 options except one.
+if(NOT CMAKE_BUILD_TYPE MATCHES Debug
+AND MSVC
+AND MSVC_VERSI
https://github.com/tru requested changes to this pull request.
Thanks for the PR, I think we at least need to make sure that we don't erase
flags that have been set by the user manually.
Another option would just to say that this configuration ARM64 + MSVC of this
version is not a valid config
https://github.com/tru edited https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lxbndr opened https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lxbndr review_requested
https://github.com/llvm/llvm-project/pull/65215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
23 matches
Mail list logo
