https://github.com/davidchisnall closed
https://github.com/llvm/llvm-project/pull/107604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/davidchisnall updated
https://github.com/llvm/llvm-project/pull/107604
>From 5fa137ce295b369b3d652e9538a4f3c13e592ad3 Mon Sep 17 00:00:00 2001
From: Frederik Carlier
Date: Fri, 6 Sep 2024 11:54:59 +
Subject: [PATCH 1/2] Set dllimport on Objective C ivar offsets
This comm
qmfrederik wrote:
@davidchisnall Yes, I don't have merge permissions on this repo; so I'd need
someone to merge it for me :-)
https://github.com/llvm/llvm-project/pull/107604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
davidchisnall wrote:
LGTM, do you need someone else to commit it for you?
https://github.com/llvm/llvm-project/pull/107604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qmfrederik wrote:
@davidchisnall and @compnerd -- anything else you need before this can get
merged?
https://github.com/llvm/llvm-project/pull/107604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
qmfrederik wrote:
Thanks @davidchisnall and @compnerd . Let me know if there's anything else you
need?
https://github.com/llvm/llvm-project/pull/107604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -1699,11 +1699,18 @@ class CGObjCGNUstep2 : public CGObjCGNUstep {
llvm::Value *EmitIvarOffset(CodeGenFunction &CGF,
const ObjCInterfaceDecl *Interface,
const ObjCIvarDecl *Ivar) override {
-const std::string
qmfrederik wrote:
I've added tests to ensure that unmarked ivars are considered protected --
which seems to be the case:
https://github.com/llvm/llvm-project/pull/107604/commits/cf93b21734e179144dac34751860b0aa9d2aedaa
https://github.com/llvm/llvm-project/pull/107604
https://github.com/qmfrederik updated
https://github.com/llvm/llvm-project/pull/107604
>From 64073399d392b187297a6aeb1c6634c271103330 Mon Sep 17 00:00:00 2001
From: Frederik Carlier
Date: Fri, 6 Sep 2024 11:54:59 +
Subject: [PATCH 1/2] Set dllimport on Objective C ivar offsets
This commit
https://github.com/davidchisnall approved this pull request.
Looks good to me. It might be worth updating the test to make sure that one
ivar is implicitly `@protected` if it isn’t already.
https://github.com/llvm/llvm-project/pull/107604
___
cfe-comm
@@ -1699,11 +1699,18 @@ class CGObjCGNUstep2 : public CGObjCGNUstep {
llvm::Value *EmitIvarOffset(CodeGenFunction &CGF,
const ObjCInterfaceDecl *Interface,
const ObjCIvarDecl *Ivar) override {
-const std::string
https://github.com/qmfrederik updated
https://github.com/llvm/llvm-project/pull/107604
>From 64073399d392b187297a6aeb1c6634c271103330 Mon Sep 17 00:00:00 2001
From: Frederik Carlier
Date: Fri, 6 Sep 2024 11:54:59 +
Subject: [PATCH] Set dllimport on Objective C ivar offsets
This commit ensu
@@ -1699,11 +1699,18 @@ class CGObjCGNUstep2 : public CGObjCGNUstep {
llvm::Value *EmitIvarOffset(CodeGenFunction &CGF,
const ObjCInterfaceDecl *Interface,
const ObjCIvarDecl *Ivar) override {
-const std::string
https://github.com/qmfrederik updated
https://github.com/llvm/llvm-project/pull/107604
>From 2b42d2048e27d30ad77a6793ae36a9b2204b4435 Mon Sep 17 00:00:00 2001
From: Frederik Carlier
Date: Fri, 6 Sep 2024 11:54:59 +
Subject: [PATCH] Set dllimport on Objective C ivar offsets
This commit ensu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 62fec3d23d2325869e6eba0263b0b9f834c2067f
83511b91e37a9191fcde289b1f302c79e8533b6f --e
qmfrederik wrote:
@davidchisnall Would you mind reviewing this PR? This came up when trying to
build gnustep-gui using the Windows-native version of LLVM/clang (i.e., not in
MSYS).
The problem is that all the ivar references are missing the `dllimport`
annotation. This is not a problem on M
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Frederik Carlier (qmfrederik)
Changes
Ensures that offsets for instance variables are marked with `dllimport` if the
interface to which they belong has this attribute.
---
Full diff: https://github.com/llvm/llvm-project/pull/107604.diff
https://github.com/qmfrederik created
https://github.com/llvm/llvm-project/pull/107604
Ensures that offsets for instance variables are marked with `dllimport` if the
interface to which they belong has this attribute.
>From 83511b91e37a9191fcde289b1f302c79e8533b6f Mon Sep 17 00:00:00 2001
From:
18 matches
Mail list logo
