[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-25 Thread Zixu Wang via cfe-commits
zixu-w wrote: Hi @zmodem ! > Could you add a release note about this, explaining how it changes the macros > and what actions users should take? That's a good idea, I should be able to put something up. > > We've already seen that it broke zlib builds, and we're having issues with > libpng t

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-24 Thread via cfe-commits
zmodem wrote: Could you add a release note about this, explaining how it changes the macros and what actions users should take? We've already seen that it broke zlib builds, and we're having issues with libpng too in Chromium (https://crbug.com/1519899), so users are likely to run into this.

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w closed https://github.com/llvm/llvm-project/pull/78353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka approved this pull request. https://github.com/llvm/llvm-project/pull/78353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zixu Wang (zixu-w) Changes https://github.com/llvm/llvm-test-suite/pull/65 fixed the llvm-test-suite errors. Reapply the change to enable `fdefine-target-os-macros` by default for Darwin targets. This reverts commit 63be986f612c175559eff

[clang] Revert "[Fix] Disable fdefine-target-os-macros for now" (PR #78353)

2024-01-16 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w created https://github.com/llvm/llvm-project/pull/78353 https://github.com/llvm/llvm-test-suite/pull/65 fixed the llvm-test-suite errors. Reapply the change to enable `fdefine-target-os-macros` by default for Darwin targets. This reverts commit 63be986f612c175559efff