[clang] Remove xbegin and _xend (PR #126952)

2025-02-24 Thread Mike Hommey via cfe-commits
glandium wrote: Should this be uplifted to release/20.x? Cc: @tstellar https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove xbegin and _xend (PR #126952)

2025-02-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove xbegin and _xend (PR #126952)

2025-02-21 Thread Devon Loehr via cfe-commits
DKLoehr wrote: Just checking in, this was approved a few days ago but hasn't been merged yet. https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] Remove xbegin and _xend (PR #126952)

2025-02-19 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove xbegin and _xend (PR #126952)

2025-02-13 Thread Devon Loehr via cfe-commits
https://github.com/DKLoehr updated https://github.com/llvm/llvm-project/pull/126952 >From 01e40e4d8b3cc2068aa5a022c3acae246b6ac771 Mon Sep 17 00:00:00 2001 From: Devon Loehr Date: Wed, 12 Feb 2025 18:17:05 + Subject: [PATCH 1/2] Remove xbegin and _xend --- clang/lib/Headers/intrin.h | 2 -

[clang] Remove xbegin and _xend (PR #126952)

2025-02-13 Thread Devon Loehr via cfe-commits
DKLoehr wrote: Added a test based on the linked bug. I couldn't get it to reproduce in anything that seemed to fit in the existing file, so I made a new one. https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lis

[clang] Remove xbegin and _xend (PR #126952)

2025-02-13 Thread Devon Loehr via cfe-commits
https://github.com/DKLoehr updated https://github.com/llvm/llvm-project/pull/126952 >From 748451908cc46416dab8ec427e8df656e61d7d94 Mon Sep 17 00:00:00 2001 From: Devon Loehr Date: Wed, 12 Feb 2025 18:17:05 + Subject: [PATCH 1/2] Remove xbegin and _xend --- clang/lib/Headers/intrin.h | 2 -

[clang] Remove xbegin and _xend (PR #126952)

2025-02-12 Thread Reid Kleckner via cfe-commits
rnk wrote: This is an observable behavior change, so it should have a test. There's a test for this header at clang/test/Headers/ms-intrins.cpp that you can extend. You probably need to add a new RUN line that adds `-mrtm` or some other micro-architectural feature so that rtmintrin.h declares

[clang] Remove xbegin and _xend (PR #126952)

2025-02-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Devon Loehr (DKLoehr) Changes `intrin.h` contains declarations for both `xbegin` and `_xend`, but they should already be included transitively from `rtmintrin.h` via `immintrin.h` and/or `x86intrin.h`. Having them in both places causes pr

[clang] Remove xbegin and _xend (PR #126952)

2025-02-12 Thread Devon Loehr via cfe-commits
https://github.com/DKLoehr created https://github.com/llvm/llvm-project/pull/126952 `intrin.h` contains declarations for both `xbegin` and `_xend`, but they should already be included transitively from `rtmintrin.h` via `immintrin.h` and/or `x86intrin.h`. Having them in both places causes prob