ayermolo wrote:
I am seeing a cmake error in one of the build steps in our enviroment:
```
CMake Error at CMakeLists.txt:86 (get_property):
get_property could not find TARGET clang-resource-headers. Perhaps it has
not yet been created.
```
Reverting this diff internally made build pass.
JDevlieghere wrote:
Hey @etcwilde, this breaks the Xcode standalone build for lldb:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/121/
The failing command in the generated script phase is:
```
cmake -E copy_directory
/Users/jonas/llvm/xcode-build/Debug/bin/LLD
https://github.com/etcwilde closed
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
Thanks, this seems good!
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/etcwilde updated
https://github.com/llvm/llvm-project/pull/88317
>From 753df93a4fc054328c0b7caacc1064c283ced8ec Mon Sep 17 00:00:00 2001
From: Evan Wilde
Date: Thu, 14 Mar 2024 18:11:24 -0700
Subject: [PATCH] Make clang resource headers an interface library
Making the clang
@@ -501,6 +501,10 @@ add_header_target("windows-resource-headers"
${windows_only_files})
add_header_target("utility-resource-headers" ${utility_files})
get_clang_resource_dir(header_install_dir SUBDIR include)
+target_include_directories(clang-resource-headers INTERFACE
+ $
@@ -501,6 +501,10 @@ add_header_target("windows-resource-headers"
${windows_only_files})
add_header_target("utility-resource-headers" ${utility_files})
get_clang_resource_dir(header_install_dir SUBDIR include)
+target_include_directories(clang-resource-headers INTERFACE
+ $
https://github.com/compnerd approved this pull request.
This seems like a step in the right direction - avoiding custom targets is
generally better.
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Evan Wilde (etcwilde)
Changes
Making the clang resource headers into an interface library instead of a custom
target means that we can attach the header search paths to the library. Targets
that "link" against this library will auto
https://github.com/etcwilde created
https://github.com/llvm/llvm-project/pull/88317
Making the clang resource headers into an interface library instead of a custom
target means that we can attach the header search paths to the library. Targets
that "link" against this library will automaticall
12 matches
Mail list logo
