[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-12-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > It would also be nice to fix the link to full `-verify` docs in > https://clang.llvm.org/docs/InternalsManual.html#the-diagnosticconsumer-interface Done. https://github.com/llvm/llvm-project/pull/73694 ___ cfe-commits mailing li

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-12-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Neato! `.. code-block: c++` should be: `.. code-block:: c++` -- did someone disable sphinx diagnostics or something? That should have been diagnosed... https://github.com/llvm/llvm-project/pull/73694 ___ cfe-commits mailing list cf

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-12-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman After moving the docs, none of the code blocks are rendering: > https://clang.llvm.org/docs/InternalsManual.html#verifying-diagnostics huh? there are zero sphinx diagnostics about the blocks, so that's exciting. https://github.com/llvm/llvm-project/pull/7369

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-12-06 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: It would also be nice to fix the link to full `-verify` docs in https://clang.llvm.org/docs/InternalsManual.html#the-diagnosticconsumer-interface https://github.com/llvm/llvm-project/pull/73694 ___ cfe-commits mailing list cfe-commits@l

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-12-06 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @AaronBallman After moving the docs, none of the code blocks are rendering: https://clang.llvm.org/docs/InternalsManual.html#verifying-diagnostics https://github.com/llvm/llvm-project/pull/73694 ___ cfe-commits mailing list cfe-commits@l

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/73694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Would it make sense to document this more publicly? While it's designed to be > an internal tool, it's really useful for people who want to make sure their > library produces high quality diagnostics (e.g. `nodiscard`, `static_assert`s > etc.). I'm sure you are aware that

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Would it make sense to document this more publicly? While it's designed to be > an internal tool, it's really useful for people who want to make sure their > library produces high quality diagnostics (e.g. nodiscard, static_asserts > etc.). I'm sure you are aware that libc++ u

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/73694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-28 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: Would it make sense to document this more publicly? While it's designed to be an internal tool, it's really useful for people who want to make sure their library produces high quality diagnostics (e.g. `nodiscard`, `static_assert`s etc.). I'm sure you are aware that libc++ us

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Urgh, I finally set a bookmark on that page, so this is going to break that! But yeah, this makes a lot more sense here, and I think ends up being easier to maintain. It passes a quick proofread, so lgtm. https://github.com/llvm/llvm-p

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes The internals manual seems like a more obvious home for the details instead of hiding them away in a header file and relying on doxygen output to document it publicly. --- Full diff: https://github.co

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/73694 The internals manual seems like a more obvious home for the details instead of hiding them away in a header file and relying on doxygen output to document it publicly. >From 12a2c85005c32e55541bc7f9ebb5492