github-actions[bot] wrote:
@CedricSwa Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a buil
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/6] Improve error message for invalid lambda captures
---
c
Sirraide wrote:
(Also, just so you know, don’t worry too much about merge conflicts in the
release notes; usually, whoever merges the pr can handle those if they’re not
too complicated)
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits
https://github.com/Sirraide commented:
Release note could still be a bit less wordy and should also include the issue
this fixes.
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -623,6 +623,8 @@ Improvements to Clang's diagnostics
- Clang no longer emits a "declared here" note for a builtin function that has
no declaration in source.
Fixes #GH93369.
+- Clang now has an improved error message when trying to capture a class
member variable for la
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/5] Improve error message for invalid lambda captures
---
c
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/5] Improve error message for invalid lambda captures
---
c
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/5] Improve error message for invalid lambda captures
---
c
@@ -622,6 +622,8 @@ Improvements to Clang's diagnostics
- Clang no longer emits a "declared here" note for a builtin function that has
no declaration in source.
Fixes #GH93369.
+- Clang now has an improved error message when trying to capture a variable
for lambda function
https://github.com/Sirraide approved this pull request.
LGTM except that the release note could be a bit more descriptive.
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/4] Improve error message for invalid lambda captures
---
c
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/4] Improve error message for invalid lambda captures
---
c
CedricSwa wrote:
not sure if lambda expression is the best file but for lambda-invalid-capture i
would need to add -Wno-unused-value to both run statements.
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/3] Improve error message for invalid lambda captures
---
c
@@ -1246,7 +1246,12 @@ void
Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro,
if (auto *BD = R.getAsSingle())
Var = BD;
- else
+ else if (auto *FD = R.getAsSingle()) {
+Var = R.getAsSingle();
Sirraide wrote:
@@ -1246,7 +1246,12 @@ void
Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro,
if (auto *BD = R.getAsSingle())
Var = BD;
- else
+ else if (auto *FD = R.getAsSingle()) {
+Var = R.getAsSingle();
CedricSwa wrote:
https://github.com/CedricSwa updated
https://github.com/llvm/llvm-project/pull/94865
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH 1/2] Improve error message for invalid lambda captures
---
c
@@ -1246,7 +1246,12 @@ void
Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro,
if (auto *BD = R.getAsSingle())
Var = BD;
- else
+ else if (auto *FD = R.getAsSingle()) {
+Var = R.getAsSingle();
Sirraide wrote:
@@ -1246,7 +1246,12 @@ void
Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro,
if (auto *BD = R.getAsSingle())
Var = BD;
- else
+ else if (auto *FD = R.getAsSingle()) {
+Var = R.getAsSingle();
Sirraide wrote:
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide commented:
This looks reasonable, but as was already pointed out, it needs a few tests,
and also a release note (in `clang/docs/ReleaseNotes.rst`, probably in the
‘Improvements to Clang’s Diagnostics’ section or whatever it was called).
https://github.com/llvm/llvm-
tschuett wrote:
Needs a test.
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: CedricSWA (CedricSwa)
Changes
close issue #94764
---
Full diff: https://github.com/llvm/llvm-project/pull/94865.diff
2 Files Affected:
- (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+2)
- (modified) clang/lib/Sema/SemaL
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/CedricSwa created
https://github.com/llvm/llvm-project/pull/94865
close issue #94764
>From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001
From: Cedric Schwarzer
Date: Sat, 8 Jun 2024 17:52:02 +0200
Subject: [PATCH] Improve error message for invalid lambda
28 matches
Mail list logo
