https://github.com/mstorsjo approved this pull request.
Looks ok to me.
I don't know about whether this really works as expected with
`corecrt_malloc.h` or not, but I would expect you to have tested it.
We could look into adding `corecrt_malloc.h` in mingw-w64 as well, and then we
could simpl
compnerd wrote:
I don't think that this fully fixes the issue as it doesn't completely break
the cycle.
https://github.com/llvm/llvm-project/pull/131668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/compnerd updated
https://github.com/llvm/llvm-project/pull/131668
>From 8415be6e59aa2f8a23a3e484b1c8053f4d0c7206 Mon Sep 17 00:00:00 2001
From: Saleem Abdulrasool
Date: Mon, 17 Mar 2025 13:31:05 -0700
Subject: [PATCH] Headers: prefer `corecrt_malloc.h` to `malloc.h`
This all
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2e6402ca2c6c33ccf41d74383a8e3afb82489410
8415be6e59aa2f8a23a3e484b1c8053f4d0c7206 --e
@@ -13,7 +13,7 @@
#include
#ifdef _WIN32
-#include
+#include
compnerd wrote:
Thanks for the typo correction!
I think that I can add in a `!defined(__MINGW32__)` condition.
https://github.com/llvm/llvm-project/pull/131668
_
@@ -13,7 +13,7 @@
#include
#ifdef _WIN32
-#include
+#include
mstorsjo wrote:
mingw-w64 doesn't have `corecrt_malloc.h` (yet), so unfortunately we can't go
this way in general. Perhaps we could for `!defined(__MINGW32__)` or
`defined(_MSC_VER)` though.
A
https://github.com/compnerd created
https://github.com/llvm/llvm-project/pull/131668
This allows us to target a lower level library (corecrt) rather than the higher
level library (ucrt) which can be helpful in mordularising the SDK.
>From f8dea4c8a85c018a3c7ef5eadd00f2da96fe1737 Mon Sep 17 00:
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Saleem Abdulrasool (compnerd)
Changes
This allows us to target a lower level library (corecrt) rather than the higher
level library (ucrt) which can be helpful in mordularising the SDK.
---
Full diff: https://github.com/llvm/llvm-pr
