[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

bricknerb wrote: Thanks for the feedback! This all makes sense. For context, I was going through some of the code and saw some formatting and thought it would be more readable to fix those. I do understand the tradeoff here, so I'll close this pull request. https://github.com/llvm/llvm-project/

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

https://github.com/bricknerb closed https://github.com/llvm/llvm-project/pull/111518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

AaronBallman wrote: Is there a need for the changes? (Are you making a significant number of changes in the file, or is this just a drive-by cleanup?) Generally, we don't do sweeping formatting changes: > Avoid committing formatting- or whitespace-only changes outside of code you > plan to ma

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

kparzysz wrote: > Right, use `git clang-format`, that will take care of formatting the file > over time without creating churn. I think the number of changes is relatively small for a file this size. The churn here is comparable to that created by a "normal" patch... https://github.com/llvm/

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

cor3ntin wrote: > Er, while it would be nice for everything to be formatted properly, this > might cause some merge conflicts with other people’s changes in `Sema.cpp` > (or at least that’s why we don’t do bulk reformatting too often iirc), so I’m > not sure we just want to format entire files

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

https://github.com/erichkeane commented: @AaronBallman should check this out, but if we're doing this, the commit needs to be added to teh 'ignore blame' file. https://github.com/llvm/llvm-project/pull/111518 ___ cfe-commits mailing list cfe-commits@

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

https://github.com/Sirraide commented: Er, while it would be nice for everything to be formatted properly, this might cause some merge conflicts with other people’s changes in `Sema.cpp` (or at least that’s why we don’t do bulk reformatting too often iirc), so I’m not sure we just want to form

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Boaz Brickner (bricknerb) Changes --- Patch is 24.54 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/111518.diff 1 Files Affected: - (modified) clang/lib/Sema/Sema.cpp (+113-100)

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

https://github.com/bricknerb created https://github.com/llvm/llvm-project/pull/111518 None >From ac3936f80c139adcbd9872d1f56ba3b24162dc9e Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Tue, 8 Oct 2024 11:44:26 +0200 Subject: [PATCH 1/2] Fix Sema::makeUnavailableInSystemHeader() indentation