https://github.com/njames93 closed
https://github.com/llvm/llvm-project/pull/100975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/100975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/100975
>From b208791fbdc9fe665f2b8ecd44c9b15a5d729f6f Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Mon, 29 Jul 2024 07:21:53 +0100
Subject: [PATCH] Fix hasName matcher assertion with inline namespaces
Fix handli
AaronBallman wrote:
> > I can't get the assertion to reproduce, but I can see the behavioral change
> > with the first matcher: https://godbolt.org/z/TcsYPoGEh
> > So this should probably come with a release note for the fix?
>
> The assertions are only shown on debug build, but it comes from
njames93 wrote:
> I can't get the assertion to reproduce, but I can see the behavioral change
> with the first matcher: https://godbolt.org/z/TcsYPoGEh
>
> So this should probably come with a release note for the fix?
The assertions are only shown on debug build, but it comes from
[here](http
https://github.com/AaronBallman commented:
I can't get the assertion to reproduce, but I can see the behavioral change
with the first matcher: https://godbolt.org/z/TcsYPoGEh
So this should probably come with a release note for the fix?
https://github.com/llvm/llvm-project/pull/100975
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/100975
>From 9e3f5ae48fa75d5db8b132162d96004191618956 Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Mon, 29 Jul 2024 07:21:53 +0100
Subject: [PATCH] Fix hasName matcher assertion with inline namespaces
Fix handli
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nathan James (njames93)
Changes
Fix handling of nodes which can be skipped in the fast path for the hasName
matcher
#100973
---
Full diff: https://github.com/llvm/llvm-project/pull/100975.diff
2 Files Affected:
- (modified) clang/lib
https://github.com/njames93 created
https://github.com/llvm/llvm-project/pull/100975
Fix handling of nodes which can be skipped in the fast path for the hasName
matcher
#100973
>From 8d1aeca42a0d544582823ff2bae0a217e14d1c02 Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Mon, 29 Jul 2024
