[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-19 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida approved this pull request. Thank you for looking into & resolving this again! https://github.com/llvm/llvm-project/pull/99399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-19 Thread via cfe-commits
https://github.com/zeroomega closed https://github.com/llvm/llvm-project/pull/99399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-18 Thread via cfe-commits
zeroomega wrote: @cyndyishida I updated the patch to use CHECK-DAG and confirm the test now pass under both XCode toolchain and our in house one. Please take a look. Thx. https://github.com/llvm/llvm-project/pull/99399 ___ cfe-commits mailing list cfe

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-18 Thread via cfe-commits
https://github.com/zeroomega updated https://github.com/llvm/llvm-project/pull/99399 >From 15ac1fc1d3e2ca29e5b7b18a794f8ad036f95368 Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Wed, 17 Jul 2024 15:45:53 -0700 Subject: [PATCH] Fix diagnostics-dsym.test on mac-arm64 The output ordering of diag

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-18 Thread via cfe-commits
zeroomega wrote: > Thank you @zeroomega ! I am also running on arm64-mac and that test is > passing. What is your `cmake` invocation? I'd like to dig into the underlying > cause of non-stable ordering. It looks like the darwin-aarch64 is passing the > test as well https://lab.llvm.org/buildbot

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-17 Thread Cyndy Ishida via cfe-commits
cyndyishida wrote: Thank you @zeroomega ! I am also running on arm64-mac and that test is passing. What is your `cmake` invocation? I'd like to dig into the underlying cause of non-stable ordering. It looks like the darwin-aarch64 is passing the test as well https://lab.llvm.org/buildbot/#/bui

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-17 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/99399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haowei (zeroomega) Changes The check ordering of diagnostics-dsym.test is wrong and it causes test failure when running on mac-arm64 machine. This patch fixes it. --- Full diff: https://github.com/llvm/llvm-project/pull/99399.diff 1 Fil

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-17 Thread via cfe-commits
https://github.com/zeroomega ready_for_review https://github.com/llvm/llvm-project/pull/99399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-17 Thread via cfe-commits
zeroomega wrote: Example of the failure: ``` TEST 'Clang :: InstallAPI/diagnostics-dsym.test' FAILED Exit Code: 1 Command Output (stderr): -- RUN: at line 4: rm -rf /Volumes/Work/s/w/ir/x/w/llvm_build/tools/clang/stage2-bins/tools/clang/test/InstallAP

[clang] Fix diagnostics-dsym.test on mac-arm64 (PR #99399)

2024-07-17 Thread via cfe-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/99399 The check ordering of diagnostics-dsym.test is wrong and it causes test failure when running on mac-arm64 machine. This patch fixes it. >From 05f1e5185f95d82f0b05b6151c37f3785baa6e54 Mon Sep 17 00:00:00 2001 F