[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-20 Thread via cfe-commits
https://github.com/cor3ntin commented: Did you check if that fixes any of the other delayed typo issues? https://github.com/llvm/llvm-project/pull/140571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-20 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/140571 >From e63781710d4f4307f4201670d96df9b511ad9551 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 19 May 2025 12:33:24 -0400 Subject: [PATCH] Fix crash with delayed typo correction Delayed typo correc

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Linux precommit CI failure looks to be unrelated. Given that this is an interaction between Sema and CodeGen, I'd like at least one approval from John or Eli before I land. https://github.com/llvm/llvm-project/pull/140571 ___ cfe-

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Delayed typo correction does not emit a diagnostic until the end of the TU. However, codegen is run on each top-level declaration unless an unrecoverable error occurred. The check for the diagnostic ensu

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/140571 Delayed typo correction does not emit a diagnostic until the end of the TU. However, codegen is run on each top-level declaration unless an unrecoverable error occurred. The check for the diagnostic ensures