https://github.com/lei137 closed
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lei137 updated
https://github.com/llvm/llvm-project/pull/104816
>From ea3a071a2255fa103f5097272b2fa896a3d4b979 Mon Sep 17 00:00:00 2001
From: Lei Huang
Date: Mon, 19 Aug 2024 12:24:31 -0400
Subject: [PATCH 1/3] Fix codegen for transparent_union function params
Update codegen
lei137 wrote:
> May it make sense to add tests with the argument passed in memory / by
> reference?
@s-barannikov Done.
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
lei137 wrote:
> s-barannikov
done.
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lei137 updated
https://github.com/llvm/llvm-project/pull/104816
>From 5ceb717b6f9ce11a12fde4aa9aaa89b4e017ef70 Mon Sep 17 00:00:00 2001
From: Lei Huang
Date: Mon, 19 Aug 2024 12:24:31 -0400
Subject: [PATCH 1/3] Fix codegen for transparent_union function params
Update codegen
https://github.com/lei137 updated
https://github.com/llvm/llvm-project/pull/104816
>From 5ceb717b6f9ce11a12fde4aa9aaa89b4e017ef70 Mon Sep 17 00:00:00 2001
From: Lei Huang
Date: Mon, 19 Aug 2024 12:24:31 -0400
Subject: [PATCH 1/2] Fix codegen for transparent_union function params
Update codegen
https://github.com/amy-kwan approved this pull request.
LGTM for using `CGT.ConvertType()` like you did previously. I agree that if we
were to do a larger/refactoring patch, that can be separate since this PR fixes
the current codegen.
https://github.com/llvm/llvm-project/pull/104816
_
s-barannikov wrote:
> However I feel like it is out of scope for what I am trying to do right now.
> Would this be better as a separate PR to change how this is handled?
Sure
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing l
lei137 wrote:
> I think the issue could be handled a different (more generic) way, by pulling
> `useFirstFieldIfTransparentUnion` to the caller and taking transparent unions
> into account when emitting LLVM IR for the formal / actual parameters
> somewhere in `CGCall.cpp`, so that ABIInfo imp
s-barannikov wrote:
I think the issue could be handled a different (more generic) way, by pulling
`useFirstFieldIfTransparentUnion` to the caller and taking transparent unions
into account when emitting LLVM IR for the formal / actual parameters somewhere
in `CGCall.cpp`, so that ABIInfo imple
s-barannikov wrote:
May it make sense to add tests with the argument passed in memory / by
reference?
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: Lei Huang (lei137)
Changes
Update codegen for func param with transparent_union attr to be that of
the first union member.
This is a followup to #101738 to fix non-ppc codegen and closes #76773.
---
Full
https://github.com/lei137 created
https://github.com/llvm/llvm-project/pull/104816
Update codegen for func param with transparent_union attr to be that of
the first union member.
This is a followup to #101738 to fix non-ppc codegen and closes #76773.
>From 25f458a6f25ff0fa21d59e30934e314da8abc
13 matches
Mail list logo
