https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/98642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> Thanks, LGTM. I like this version.
Thank you for the excellent review, I think we came to a better approach in the
end!
> Did this change also fix any other bugs? Since it looks like we were
> previously not skipping ProcessDeclAttribute for `[[]]` attributes in C23
> m
https://github.com/jyknight approved this pull request.
Thanks, LGTM. I like this version.
Did this change also fix any other bugs? Since it looks like we were previously
not skipping ProcessDeclAttribute for ``[[]]`` attributes in C23 mode, when
IncludeCXX11Attributes == false, and we were su
AaronBallman wrote:
> The part I'm confused about is that this commit doesn't appear to simply be
> adding "or `alignas`" to some code that said "if `_Alignas`". Yes, the newly
> added `isAlignas()` checks do cover both attributes, but `_Alignas` was still
> working even after
> [b9cf7f1](htt
jyknight wrote:
The part I'm confused about is that this commit doesn't appear to simply be
adding "or `alignas`" to some code that said "if `_Alignas`". Yes, the newly
added `isAlignas()` checks do cover both attributes, but `_Alignas` was still
working even after b9cf7f1.
That is, in clang
AaronBallman wrote:
> I'm not sure I understand what happened here, since `_Alignas` did work
> properly before this change, right? How/why are `_Alignas` and `alignas`
> acting differently from eachother in C23 mode?
`_Alignas` on a field used to work properly before
b9cf7f1066cc7ec11c6074d1
jyknight wrote:
I'm not sure I understand what happened here, since `_Alignas` did work
properly before this change, right? How/why are `_Alignas` and `alignas` acting
differently from eachother in C23 mode?
https://github.com/llvm/llvm-project/pull/98642
__
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/98642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
This was a 19.x regression and thus has no release note.
Fixes #95032
---
Full diff: https://github.com/llvm/llvm-project/pull/98642.diff
5 Files Affected:
- (modified) clang/include/clang/Sema/Decl
