AaronBallman wrote:
Whoops, I clicked too soon, so I closed the revert PR, sorry for that noise.
I think this is a spurious failure unrelated to your changes, so you can ignore
the issue.
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commi
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building
`clang` at step 7 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/73/builds/11461
Here is the r
https://github.com/AaronBallman approved this pull request.
LGTM but I added our cmake code owners just in case they have the bandwidth to
also double-check, since I got this wrong before. :-)
https://github.com/llvm/llvm-project/pull/119403
___
cfe-c
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd wrote:
(waiting to see if Aaron can also take a look)
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
paulhuggett wrote:
> I guess I must of broke build for the MSVC MSBuild/vcxproj CMake generator
(Thanks for the reply, and apologies for the slow response.) I've spent time
trying to properly understand the flow through the add_clang_library and
add_llvm_library. As far as I can tell, the impl
fsfod wrote:
I guess I must of broke build for the MSVC MSBuild/vcxproj CMake generator as
well, maybe it can use the same kind checks as earlier code like this
``` cmake
if(NOT XCODE AND NOT MSVC_IDE)
target_compile_definitions("obj.${name}" PUBLIC CLANG_EXPORTS)
else()
target_compile_defin
paulhuggett wrote:
Sorry, I should have mentioned the authors of commit 09fa2f012fcc: @fsfod and
@AaronBallman.
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/paulhuggett edited
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paulhuggett edited
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Paul Bowen-Huggett (paulhuggett)
Changes
I’m seeing a series of errors when trying to run the cmake configure step on
macOS when the cmake generator is set to Xcode. All is well if I use the Ninja
or Unix Makefile generators. Messages are
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/paulhuggett created
https://github.com/llvm/llvm-project/pull/119403
I’m seeing a series of errors when trying to run the cmake configure step on
macOS when the cmake generator is set to Xcode. All is well if I use the Ninja
or Unix Makefile generators. Messages are all of t
14 matches
Mail list logo
