[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-18 Thread Daniel M. Katz via cfe-commits
katzdm wrote: > @katzdm Does it make sense to file an issue so we don't forget to bring the > warning back? Yep, for sure - I've opened #92656. https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-17 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: @katzdm Does it make sense to file an issue so we don't forget to bring the warning back? https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-16 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: clang already generates certain diagnostics from ExprConstant; expanding the set of diagnostics could be reasonable. Alternatively, we could try to add some sort of cooperation between DiagRuntimeBehavior and constant evaluation, to try to avoid having to diagnose everyth

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-16 Thread Daniel M. Katz via cfe-commits
katzdm wrote: @Fznamznon Hmm...my suggested change does seem to break some tests :( But to circle back to your original question, I think it's not totally unexpected - a broader class of variable initializers are now (correctly afaict) evaluated as constant expressions, which could make some

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-16 Thread Daniel M. Katz via cfe-commits
katzdm wrote: > @katzdm It seems after this a `warn_impcast_integer_precision_constant` > warning went missing: > > https://godbolt.org/z/ndsPb44b4 > > Is that expected? We changed [this diagnostic](https://github.com/llvm/llvm-project/blob/5ac34358181b21135851979c1c949632be5a9d32/clang/lib/

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-16 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: @katzdm It seems after this a `warn_impcast_integer_precision_constant` warning went missing: https://godbolt.org/z/ndsPb44b4 Is that expected? https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commit

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-09 Thread via cfe-commits
cor3ntin wrote: CI failures look unrelated https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-08 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm updated https://github.com/llvm/llvm-project/pull/89565 >From 218ffb6d5a03c96d46bfecdb4490277809f5b62e Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Tue, 16 Apr 2024 17:14:50 -0400 Subject: [PATCH 1/8] Fix bug with constexpr initialization. --- clang/lib/Parse/ParseD

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-08 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm updated https://github.com/llvm/llvm-project/pull/89565 >From 218ffb6d5a03c96d46bfecdb4490277809f5b62e Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Tue, 16 Apr 2024 17:14:50 -0400 Subject: [PATCH 1/8] Fix bug with constexpr initialization. --- clang/lib/Parse/ParseD

[clang] [Clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-08 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-08 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/89565 >From 218ffb6d5a03c96d46bfecdb4490277809f5b62e Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Tue, 16 Apr 2024 17:14:50 -0400 Subject: [PATCH 1/8] Fix bug with constexpr initialization. --- clang/lib/Parse/Pars

[clang] Fix P2564 handling of variable initializers (PR #89565)

2024-05-07 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm edited https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits