[clang] Fix #99858 (PR #99859)

2024-07-26 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: My impression is that in this case, the Decl is supposed to be instantiated here, so in valid code, a instantiation would be found, so strictly speaking the null check would not be the right thing. But we do have cases where we don't instantiate in case the Decl is invalid. In

[clang] Fix #99858 (PR #99859)

2024-07-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for submitting a potential fix. First of all this needs a reproducer, one to verify the existing issue and two because we need to add a test to insure we fix and three we need the rest to make sure we don't regress the fix in later releases. The

[clang] Fix #99858 (PR #99859)

2024-07-22 Thread Ahmet Faruk Aktaş via cfe-commits
ahfakt wrote: I tried to represent the error with a sample code but can not reproduce. It may be removed because of unused template function optimization. In my project it is in a template library which is not a compiled context. I just wanted to point the issue so someone who is experienced i

[clang] Fix #99858 (PR #99859)

2024-07-22 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 commented: Do you have a test against your changes? This also needs a release note. https://github.com/llvm/llvm-project/pull/99859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] Fix #99858 (PR #99859)

2024-07-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ahmet Faruk Aktaş (ahfakt) Changes Fix crash caused by template parameter pack expansion when no instantiation exist. --- Full diff: https://github.com/llvm/llvm-project/pull/99859.diff 1 Files Affected: - (modified) clang/lib/Sema/Sem

[clang] Fix #99858 (PR #99859)

2024-07-22 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix #99858 (PR #99859)

2024-07-22 Thread Ahmet Faruk Aktaş via cfe-commits
https://github.com/ahfakt created https://github.com/llvm/llvm-project/pull/99859 Fix crash caused by template parameter pack expansion when no instantiation exist. From a84e2af497f827996afe9a820904f9f1d2f9fb22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ahmet=20Faruk=20Akta=C5=9F?= Date: Mon, 2