[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-08-23 Thread via cfe-commits
@@ -166,7 +155,7 @@ static bool useFramePointerForTargetByDefault(const llvm::opt::ArgList &Args, static bool useLeafFramePointerForTargetByDefault(const llvm::Triple &Triple) { if (Triple.isAArch64() || Triple.isPS() || Triple.isVE() || - (Triple.isAndroid() && Triple

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-08-23 Thread via cfe-commits
@@ -166,7 +155,7 @@ static bool useFramePointerForTargetByDefault(const llvm::opt::ArgList &Args, static bool useLeafFramePointerForTargetByDefault(const llvm::Triple &Triple) { if (Triple.isAArch64() || Triple.isPS() || Triple.isVE() || - (Triple.isAndroid() && Triple

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-08-23 Thread Sam Elliott via cfe-commits
@@ -166,7 +155,7 @@ static bool useFramePointerForTargetByDefault(const llvm::opt::ArgList &Args, static bool useLeafFramePointerForTargetByDefault(const llvm::Triple &Triple) { if (Triple.isAArch64() || Triple.isPS() || Triple.isVE() || - (Triple.isAndroid() && Triple

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/1173 Here is the relevant piece of the bu

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-08 Thread via cfe-commits
https://github.com/yabinc closed https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/yabinc updated https://github.com/llvm/llvm-project/pull/97614 >From 3a705f4ce3e35a7a04b1d7002f36d77a617ba2e0 Mon Sep 17 00:00:00 2001 From: Yabin Cui Date: Wed, 3 Jul 2024 11:03:35 -0700 Subject: [PATCH] Enable frame pointer for non-leaf functions on Android On Android, we

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread Stephen Hines via cfe-commits
https://github.com/stephenhines approved this pull request. Looks great! Thanks for making this more consistent. https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/enh-google approved this pull request. yeah, that looks more like what i was expecting to see :-) https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
yabinc wrote: Currently, we have frame pointer only for non-leaf functions for AArch64, RISCV64, and frame pointer for all functions for ARM. I feel frame pointer for leaf functions isn't needed to unwind a callstack (For the leaf function, we already have the IP register pointing to the leaf

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
yabinc wrote: I forgot part of the change. Now it is fixed. https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/yabinc updated https://github.com/llvm/llvm-project/pull/97614 >From d66a8a2a6022cd1cb3aa57fb74527f662c0ff4a3 Mon Sep 17 00:00:00 2001 From: Yabin Cui Date: Wed, 3 Jul 2024 11:03:35 -0700 Subject: [PATCH] Enable frame pointer for non-leaf functions on Android On Android, we

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/enh-google approved this pull request. commit message says "non-leaf" but the function says "leaf"? (regardless, i support more use of frame pointers on Android...) https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mai

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (yabinc) Changes On Android, we always want frame pointers to make debugging in the field easier. Since frame pointers are already enabled for AArch64, ARM and RISCV64, effectively this change further enables frame pointers fo

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/yabinc created https://github.com/llvm/llvm-project/pull/97614 On Android, we always want frame pointers to make debugging in the field easier. Since frame pointers are already enabled for AArch64, ARM and RISCV64, effectively this change further enables frame pointers for X