[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-12-13 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/71446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-12-13 Thread Tom Stellard via cfe-commits
tstellar wrote: Closing in favor of #73214 . https://github.com/llvm/llvm-project/pull/71446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-07 Thread Tom Stellard via cfe-commits
tstellar wrote: > I think I have expressed I wanted to say... The new probing semantics seems > really unusual to me. I do not feel that how path-related options usually > behave. > @MaskRay Ok, what do you think would be a good alternative? Another solution I considered was to have --gcc-i

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: I think I have expressed I wanted to say... The new probing semantics seems really unusual to me. I do not feel that how path-related options usually behave. https://github.com/llvm/llvm-project/pull/71446 ___ cfe-commits mailing list

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread Tom Stellard via cfe-commits
tstellar wrote: > When your system GCC moves 12 to 13, do you remove > `/usr/lib/gcc/x86_64-linux-gnu/12` and add `/usr/lib/gcc/x86_64-linux-gnu/13` > atomically? Yes. > Gentoo doesn't seem to have more driver option requirement. Perhaps @mgorny > @thesamesam can talk about they upgrade GCC

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: > The downside of the --gcc-install-dir is that you are required to specify a > path that includes the gcc major version. This makes it hard to use for > distributions in configuration files, because an upgrade of gcc would cause > clang to stop working. --gcc-install-dir speci

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bc7a3bd864be696217c4d11eddf16bed7646b60f 2474aad8585829936af66d8b1238a1876c0f8327 --

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Stellard (tstellar) Changes The downside of the --gcc-install-dir is that you are required to specify a path that includes the gcc major version. This makes it hard to use for distributions in configuration files, because an upgrade

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Tom Stellard (tstellar) Changes The downside of the --gcc-install-dir is that you are required to specify a path that includes the gcc major version. This makes it hard to use for distributions in configuration files, because an u

[clang] Driver: Accept the --gcc-install-dir option multiple times (PR #71446)

2023-11-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/71446 The downside of the --gcc-install-dir is that you are required to specify a path that includes the gcc major version. This makes it hard to use for distributions in configuration files, because an upgrade of g