[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/134374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-05 Thread Mariya Podchishchaeva via cfe-commits
@@ -319,6 +319,9 @@ Improvements to Clang's diagnostics - ``-Wc++98-compat`` no longer diagnoses use of ``__auto_type`` or ``decltype(auto)`` as though it was the extension for ``auto``. (#GH47900) +- Now correctly diagnose use of a tentative definition of an array with stat

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-04 Thread Aaron Ballman via cfe-commits
@@ -3,16 +3,15 @@ -struct foo; // c-note 5 {{forward declaration of 'struct foo'}} \ +struct foo; // c-note 4 {{forward declaration of 'struct foo'}} \ cxx-note 3 {{forward declaration of 'foo'}} void b; // expected-error {{variable has incomplete type 'v

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/134374 >From 753208a20b2a4caf6186fa647c4abfef546e5685 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Fri, 4 Apr 2025 08:29:55 -0400 Subject: [PATCH 1/2] Correctly diagnose incomplete arrays with static storage

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-04 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon approved this pull request. I'm not super familiar with the affected area, but it looks good to me https://github.com/llvm/llvm-project/pull/134374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-04 Thread Mariya Podchishchaeva via cfe-commits
@@ -3,16 +3,15 @@ -struct foo; // c-note 5 {{forward declaration of 'struct foo'}} \ +struct foo; // c-note 4 {{forward declaration of 'struct foo'}} \ cxx-note 3 {{forward declaration of 'foo'}} void b; // expected-error {{variable has incomplete type 'v

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes A file scope declaration without an initializer which is neither extern nor thread_local is a tentative definition. If the declaration of an identifier for an object is a tentative definition and has i

[clang] Correctly diagnose incomplete arrays with static storage in C (PR #134374)

2025-04-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/134374 A file scope declaration without an initializer which is neither extern nor thread_local is a tentative definition. If the declaration of an identifier for an object is a tentative definition and has inter