[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-09 Thread David Salinas via cfe-commits
https://github.com/david-salinas updated https://github.com/llvm/llvm-project/pull/97668 >From 838ea93f30e9e421ad9948618cfcb61703d94029 Mon Sep 17 00:00:00 2001 From: David Salinas Date: Thu, 4 Jul 2024 03:32:13 + Subject: [PATCH] Remove Linux path names in ROCm search paths on Windows

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-09 Thread Yaxun Liu via cfe-commits
@@ -0,0 +1,7 @@ +// UNSUPPORTED: system-linux yxsamliu wrote: You may need `// REQUIRES: system-windows` since only on Windows these paths are not added. https://github.com/llvm/llvm-project/pull/97668 ___ cfe-commits

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-09 Thread Jay Foad via cfe-commits
jayfoad wrote: > Compiler messages on HIP SDK for Windows Please rewrite this to say what the patch does or what problem it fixes. https://github.com/llvm/llvm-project/pull/97668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-08 Thread David Salinas via cfe-commits
https://github.com/david-salinas updated https://github.com/llvm/llvm-project/pull/97668 >From 970b1e696b77216f326fb7d8dcad5b55a82db489 Mon Sep 17 00:00:00 2001 From: David Salinas Date: Thu, 4 Jul 2024 03:32:13 + Subject: [PATCH] Compiler messages on HIP SDK for Windows When target

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-08 Thread David Salinas via cfe-commits
https://github.com/david-salinas updated https://github.com/llvm/llvm-project/pull/97668 >From e9722655b4fd32b3128ba10b69b1b498e507d437 Mon Sep 17 00:00:00 2001 From: David Salinas Date: Thu, 4 Jul 2024 03:32:13 + Subject: [PATCH] Compiler messages on HIP SDK for Windows When target

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-04 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: better add a lit test like https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/rocm-detect.hip , but for windows only (`REQUIRES: system-windows`), using `--print-rocm-search-dirs`, and checks `ROCm installation search path`. https://github.com/llvm/llvm-project/p

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 845dee36ba4161df153ba05009cea615e20eda5a eb83f777e5e15f2602b34b0ba48d1cf5ac803d16 --

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: David Salinas (david-salinas) Changes When target triple indicates we are on Windows, do not add linux paths to search path in ROCm Installation Detection. Change-Id: I18effb8c20252de3d84ea37ef562124695c5a570 --- Full

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-03 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Compiler messages on HIP SDK for Windows (PR #97668)

2024-07-03 Thread David Salinas via cfe-commits
https://github.com/david-salinas created https://github.com/llvm/llvm-project/pull/97668 When target triple indicates we are on Windows, do not add linux paths to search path in ROCm Installation Detection. Change-Id: I18effb8c20252de3d84ea37ef562124695c5a570 >From eb83f777e5e15f26