nikic wrote:
> GVN seems to have different behavior regarding LoopInfo in the LegacyPM and
> NewPM, but that's an orthogonal issue. I'll check whether always requiring
> LoopInfo in GVN has any compile-time impact, as I don't think this is
> supposed to be an optional analysis there (otherwise
jayfoad wrote:
> I guess I don't know how pull requests and reviewing works in github. I
> actually added 3 comments on this patch a several days (or weeks) ago. But
> turns out that they were "pending" because I had only "started review" and
> not found the place to "submit review".
For that
@@ -935,7 +935,7 @@ bool
AArch64ConditionalCompares::runOnMachineFunction(MachineFunction &MF) {
SchedModel = MF.getSubtarget().getSchedModel();
MRI = &MF.getRegInfo();
DomTree = &getAnalysis();
- Loops = getAnalysisIfAvailable();
+ Loops = &getAnalysis();
https://github.com/bjope edited https://github.com/llvm/llvm-project/pull/65729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -261,7 +261,7 @@ bool VirtRegRewriter::runOnMachineFunction(MachineFunction
&fn) {
Indexes = &getAnalysis();
LIS = &getAnalysis();
VRM = &getAnalysis();
- DebugVars = getAnalysisIfAvailable();
+ DebugVars = &getAnalysis();
bjope wrote:
Not sure how
@@ -3280,7 +3280,7 @@ class llvm::gvn::GVNLegacyPass : public FunctionPass {
if (skipFunction(F))
return false;
-auto *LIWP = getAnalysisIfAvailable();
+auto &LIWP = getAnalysis();
bjope wrote:
IIUC GVN doesn't depend on LoopInfo itself. It
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/65729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: Jay Foad (jayfoad)
Changes
After a pass calls addRequired() it is strange to call
getAnalysisIfAvailable() because analysis X should always be
available. Use getAnalysis() instead.
---
Full diff: https://github.com/llvm
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/65729
>From 66129acffd34a4b0f2c8a956d88212ed2ee30946 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Fri, 8 Sep 2023 10:09:21 +0100
Subject: [PATCH] Clean up strange uses of getAnalysisIfAvailable
After a pass calls add
