alexcrichton wrote:
I can see how the current state of the world is resulting in this PR, but at
least personally I continue to feel that a warning should not be emitted if no
flags are passed and `wasm-opt` is not found. Part of it I've [mentioned
above](https://github.com/llvm/llvm-project/p
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Quentin Michaud (mh4ck-Thales)
Changes
Add a warning when `wasm-opt` is requested with a flag (#95208) but is
not found in the path.
I'm using #77148 as reference on how to add a new warning but please
tell me if you can help in i
https://github.com/mh4ck-Thales ready_for_review
https://github.com/llvm/llvm-project/pull/100321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mh4ck-Thales wrote:
I implemented a proposition on how to proceed for correctly informing users of
wasm-opt problems:
- a warning for when no flags are passed (the default being wasm-opt enabled
for wasip1) and wasm-opt is not found
- an error for when --wasm-opt is explicitly passed but wasm-o
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 73ef397fcba35b7b4239c00bf3e0b4e689ca0add
a798b1fd7a7a6c7b782584021e5c32e52c3abffc --e
https://github.com/mh4ck-Thales updated
https://github.com/llvm/llvm-project/pull/100321
>From b812b9c2a7b92edf5dab739eadff0295c2a1f631 Mon Sep 17 00:00:00 2001
From: Quentin Michaud
Date: Wed, 24 Jul 2024 09:54:53 +0200
Subject: [PATCH 1/2] First draft of wasm-opt warning
---
clang/lib/Drive
alexcrichton wrote:
Personally I don't find it to be a great user experience when a tool warns by
default in default configration. This means that any user using wasi-sdk, for
example, would by default with no other action taken receive warnings. That's
annoying and misleading to end users bec
mh4ck-Thales wrote:
`wasm-opt` is enabled by default for WASIp1, but can be disabled with the
`--no-wasm-opt` flag. Indeed if it is explicitly enabled then an error instead
of a warning would make more sense.
I'm not sure what is the problem with
> most developers I know of on wasm32-wasip1
alexcrichton wrote:
If wasm-opt is explicitly enabled via a flag, then I think it would make sense
for this to be an error rather than a warning. Otherwise though if no default
behavior was indicated then I would personally fear the churn of this change as
most developers I know of on `wasm32-
https://github.com/mh4ck-Thales created
https://github.com/llvm/llvm-project/pull/100321
Add a warning when `wasm-opt` is requested with a flag (#95208) but is not
found in the path.
I'm using #77148 as reference on how to add a new warning but please tell me if
you can help in implementing t
10 matches
Mail list logo
