[clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/GeorgeKA created https://github.com/llvm/llvm-project/pull/133806 Alias template class template argument deduction is a documented C++20 feature. C++17 also happens to support it, but there is no message output to indicate the officially supported version. This PR adds that

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/erichkeane approved this pull request. Perfect, thanks! Whoever notices that CI is happy can merge this. Remind us if you notice/cannot. https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lis

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -9920,7 +9920,9 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (auto *AliasTemplate = dyn_cast_or_null( TemplateName.getAsTemplateDecl())) { Diag(Kind.getLocation(), - diag::warn_cxx17_compat_ctad_for_alias_templates); +

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (GeorgeKA) Changes Alias template class template argument deduction is a documented C++20 feature. C++17 also happens to support it, but there is no message output to indicate the officially supported version. This PR adds that. Al

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -9920,7 +9920,9 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (auto *AliasTemplate = dyn_cast_or_null( TemplateName.getAsTemplateDecl())) { Diag(Kind.getLocation(), - diag::warn_cxx17_compat_ctad_for_alias_templates); +

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/GeorgeKA updated https://github.com/llvm/llvm-project/pull/133806 >From dd978982b2ab41d3d2a55abb448e653a80158ecd Mon Sep 17 00:00:00 2001 From: George Asante Date: Mon, 31 Mar 2025 17:41:20 -0400 Subject: [PATCH 1/4] Add warning message for C++17 alias template CTAD --- cla

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

Sirraide wrote: (grep for `DiagCompat()` if you’re unsure as to what to do) https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -9920,7 +9920,9 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (auto *AliasTemplate = dyn_cast_or_null( TemplateName.getAsTemplateDecl())) { Diag(Kind.getLocation(), - diag::warn_cxx17_compat_ctad_for_alias_templates); +

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

GeorgeKA wrote: > thanks. will you need us to merge that for you? Yes, if you wouldn't mind @cor3ntin . The checks have passed https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

erichkeane wrote: Please dont' merge this until it is rebased on top of @Sirrade's patch and the SemaInit.cpp uses the new interface instead. https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/GeorgeKA edited https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/GeorgeKA updated https://github.com/llvm/llvm-project/pull/133806 >From dd978982b2ab41d3d2a55abb448e653a80158ecd Mon Sep 17 00:00:00 2001 From: George Asante Date: Mon, 31 Mar 2025 17:41:20 -0400 Subject: [PATCH 1/3] Add warning message for C++17 alias template CTAD --- cla

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -9920,7 +9920,9 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (auto *AliasTemplate = dyn_cast_or_null( TemplateName.getAsTemplateDecl())) { Diag(Kind.getLocation(), - diag::warn_cxx17_compat_ctad_for_alias_templates); +

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -9920,7 +9920,9 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (auto *AliasTemplate = dyn_cast_or_null( TemplateName.getAsTemplateDecl())) { Diag(Kind.getLocation(), - diag::warn_cxx17_compat_ctad_for_alias_templates); +

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/mizvekov approved this pull request. LGTM, thanks for working on this. Please add a release note before merging. https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [Clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/cor3ntin approved this pull request. thanks. will you need us to merge that for you? https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -49,6 +49,8 @@ defm constexpr_ctor_missing_init : CXX20Compat< defm adl_only_template_id : CXX20Compat< "use of function template name with no prior declaration in function call " "with explicit template arguments is">; +defm ctad_for_alias_templates Sir

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/GeorgeKA deleted https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/GeorgeKA updated https://github.com/llvm/llvm-project/pull/133806 >From dd978982b2ab41d3d2a55abb448e653a80158ecd Mon Sep 17 00:00:00 2001 From: George Asante Date: Mon, 31 Mar 2025 17:41:20 -0400 Subject: [PATCH 1/2] Add warning message for C++17 alias template CTAD --- cla

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -8444,9 +8444,16 @@ let CategoryName = "Lambda Issue" in { "C++ standards before C++20">, InGroup, DefaultIgnore; // C++20 class template argument deduction for alias templates. - def warn_cxx17_compat_ctad_for_alias_templates : Warning< - "class template argument d

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -8444,9 +8444,16 @@ let CategoryName = "Lambda Issue" in { "C++ standards before C++20">, InGroup, DefaultIgnore; // C++20 class template argument deduction for alias templates. - def warn_cxx17_compat_ctad_for_alias_templates : Warning< - "class template argument d

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

@@ -8444,9 +8444,16 @@ let CategoryName = "Lambda Issue" in { "C++ standards before C++20">, InGroup, DefaultIgnore; // C++20 class template argument deduction for alias templates. - def warn_cxx17_compat_ctad_for_alias_templates : Warning< - "class template argument d

[clang] Add warning message for C++17 alias template CTAD (PR #133806)

GeorgeKA wrote: @mizvekov requesting review please and thanks. The goal now is simply to let the user know the officially supported version when the feature is used with C++17. https://github.com/llvm/llvm-project/pull/133806 ___ cfe-commits mailing l