[clang] Add flag to opt out of wasm-opt (PR #95208)

sunfishcode wrote: @mh4ck-Thales Yes; even if we don't get it in before the release branch is created, I think it'd be reasonable to backport a patch to the release branch. https://github.com/llvm/llvm-project/pull/95208 ___ cfe-commits mailing list c

[clang] Add flag to opt out of wasm-opt (PR #95208)

pavelsavara wrote: I would also love to see https://github.com/llvm/llvm-project/pull/98373 merged. Thank you. https://github.com/llvm/llvm-project/pull/95208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] Add flag to opt out of wasm-opt (PR #95208)

mh4ck-Thales wrote: @sbc100 I tried to limit the scope of this new option to Wasm using the corresponding group in `Options.td` (https://github.com/ThalesGroup/llvm-project/blob/8c7052d5da074eb1d754aeddc4257d33e4e299aa/clang/include/clang/Driver/Options.td#L222), but for some reason I was unab

[clang] Add flag to opt out of wasm-opt (PR #95208)

alexcrichton wrote: I've opened https://github.com/llvm/llvm-project/pull/98373 to avoid running `wasm-opt` for the `wasm32-wasip2` target by default. It also fixes a minor issue with this PR where if `wasm-opt` were disabled it would skip running the linker entirely. https://github.com/llvm/

[clang] Add flag to opt out of wasm-opt (PR #95208)

sbc100 wrote: I think should never not be running wasm-opt when the linker is wasm-component-ld. Thats not going to work, at least not any time soon. How to integrate wasm-opt into wasm-component-ld is a good question. I imagine @alexcrichton has some ideas in that area. https://github.co

[clang] Add flag to opt out of wasm-opt (PR #95208)

pavelsavara wrote: I don't know who needs to hear this, but I got bitten by `wasm-opt` being on my PATH (while using WASI SDK 22). I was trying to compile zlib-ng for WASIp2 and it's CMake platform detection was passing `-O3` to `check_type_size("void *" SIZEOF_DATA_PTR)` It worked on some mac

[clang] Add flag to opt out of wasm-opt (PR #95208)

sunfishcode wrote: @mh4ck-Thales A warning could be useful in some situations, but I also don't know how to navigate the situation with existing users using `-Werror`. @sbc100 I'm open to ideas for how to limit the scope to wasm in some way. https://github.com/llvm/llvm-project/pull/95208

[clang] Add flag to opt out of wasm-opt (PR #95208)

sbc100 wrote: I wonder if there is some why to avoiding adding this new option globally like this and instead limit it in scope the wasm target in some way? https://github.com/llvm/llvm-project/pull/95208 ___ cfe-commits mailing list cfe-commits@li

[clang] Add flag to opt out of wasm-opt (PR #95208)

github-actions[bot] wrote: @mh4ck-Thales Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a b

[clang] Add flag to opt out of wasm-opt (PR #95208)

https://github.com/sunfishcode closed https://github.com/llvm/llvm-project/pull/95208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flag to opt out of wasm-opt (PR #95208)

mh4ck-Thales wrote: Any opinion on whether to implement a warning or not ? https://github.com/llvm/llvm-project/pull/95208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flag to opt out of wasm-opt (PR #95208)

https://github.com/sunfishcode approved this pull request. This looks good to me. https://github.com/llvm/llvm-project/pull/95208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flag to opt out of wasm-opt (PR #95208)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Quentin Michaud (mh4ck-Thales) Changes This PR fixes #55781 by adding the `--no-wasm-opt` and `--wasm-opt` flags in clang to disable/enable the `wasm-opt` optimizations. The default is to enable `wasm-opt` as before in order to no

[clang] Add flag to opt out of wasm-opt (PR #95208)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Add flag to opt out of wasm-opt (PR #95208)

https://github.com/mh4ck-Thales created https://github.com/llvm/llvm-project/pull/95208 This PR fixes #55781 by adding the `--no-wasm-opt` and `--wasm-opt` flags in clang to disable/enable the `wasm-opt` optimizations. The default is to enable `wasm-opt` as before in order to not break existi