https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
khyperia wrote:
@cachemeifyoucan thank you, done! (feel free to rewrite it as well, if you want
or have any nitpicks)
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/khyperia edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@khyperia Sure, I can help you merge. Code change looks good as I don't see any
open review feedback and no objection from adding the option.
Can you please update the PR message to be a better formatted commit message?
The squash commit will use that as commit message,
khyperia wrote:
@cachemeifyoucan Could you possibly help me get this merged? I'm not sure if
your approval is enough, or if more reviewers are needed - and if so, who. Are
you able to merge this if just your approval is enough?
https://github.com/llvm/llvm-project/pull/121231
_
khyperia wrote:
> It is better to add a CLANG_DEFAULT_LIPO cmake option to match the
> CLANG_DEFAULT_LINKER for -fuse-ld.
Sure, that's a possibility, but in my opinion can be done in a future PR.
There's a lot of additional features that can be done in the future:
- CLANG_DEFAULT_LIPO cmake o
Andarwinux wrote:
It is better to add a CLANG_DEFAULT_LIPO cmake option to match the
CLANG_DEFAULT_LINKER for -fuse-ld.
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
> I tried to take precedence from -fuse-ld and --ld-path, so -fuse-lipo takes a
> name, and a hypothetical future --lipo-path would be a full path. Perhaps
> these are only named this way due to legacy compatibility though, and new
> naming conventions should be somethin
khyperia wrote:
(For what it's worth, just confirming that the current code doesn't work with a
full path - it surprisingly kind of almost does, but not quite, due to quirks
of `GetProgramPath`)
https://github.com/llvm/llvm-project/pull/121231
___
cf
khyperia wrote:
> LGTM in general with a comment in test.
>
> For discussion. Is it better if the option supplies the full path to lipo or
> just the name? Full path seems to be easy to use, but might deserve a warning
> if the tool doesn't exist. If just the name, it might be better to rename
https://github.com/khyperia updated
https://github.com/llvm/llvm-project/pull/121231
>From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001
From: khyperia
Date: Fri, 27 Dec 2024 23:03:58 +0100
Subject: [PATCH 1/3] Add -fuse-lipo option
---
clang/include/clang/Driver/Options.t
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan commented:
LGTM in general with a comment in test.
For discussion. Is it better if the option supplies the full path to lipo or
just the name? Full path seems to be easy to use, but might deserve a warning
if the tool doesn't exist.
If just the name, it might
@@ -0,0 +1,11 @@
+// RUN: %clang %s -### --target=arm64-apple-darwin -arch x86_64 -arch arm64
-fuse-lipo=llvm-lipo 2>&1 | FileCheck -check-prefix=TEST1 %s
cachemeifyoucan wrote:
Nit: Add a test case to check when the flag is not supplied.
https://github.com/llv
khyperia wrote:
@carlocab I've removed the temporary std::string and added a guess at basic
tests. Let me know if there's additional tests in particular that you're
thinking of!
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing
https://github.com/khyperia updated
https://github.com/llvm/llvm-project/pull/121231
>From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001
From: khyperia
Date: Fri, 27 Dec 2024 23:03:58 +0100
Subject: [PATCH 1/2] Add -fuse-lipo option
---
clang/include/clang/Driver/Options.t
@@ -910,7 +910,10 @@ void darwin::Lipo::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(II.getFilename());
}
- const char *Exec = Args.MakeArgString(getToolChain().GetProgramPath("lipo"));
+ std::string LipoName =
+ std::string(Args.getLastArg
@@ -910,7 +910,10 @@ void darwin::Lipo::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(II.getFilename());
}
- const char *Exec = Args.MakeArgString(getToolChain().GetProgramPath("lipo"));
+ std::string LipoName =
+ std::string(Args.getLastArg
https://github.com/carlocab commented:
Thanks for the PR! This change needs new tests to be added.
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/carlocab edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/khyperia updated
https://github.com/llvm/llvm-project/pull/121231
>From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001
From: khyperia
Date: Fri, 27 Dec 2024 23:03:58 +0100
Subject: [PATCH] Add -fuse-lipo option
---
clang/include/clang/Driver/Options.td |
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 815343e7dd32cc4c5c903ac52daf87aaa4e4cd6e
51401ec4a8af7d926ba3c9faa818ecb9c68c0db7 --e
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ashley Hauck (khyperia)
Changes
This is my first LLVM PR! Please feel free to provide feedback/etc. - I am
especially unsure about the `Options.td` change - I just kind of guessed here.
Partially fixes https://github.com/llvm/llvm-project
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Ashley Hauck (khyperia)
Changes
This is my first LLVM PR! Please feel free to provide feedback/etc. - I am
especially unsure about the `Options.td` change - I just kind of guessed here.
Partially fixes https://github.com/llvm/llvm-
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/khyperia created
https://github.com/llvm/llvm-project/pull/121231
This is my first LLVM PR! Please feel free to provide feedback/etc. - I am
especially unsure about the `Options.td` change - I just kind of guessed here.
Partially fixes https://github.com/llvm/llvm-project/is
28 matches
Mail list logo
