https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Something got screwed up when I tried to squash all but the first commit
together. I put it back together manually. The NFC commit was pushed as
9500616, the functional stuff squashed and committed as 71d83bb.
https://github.com/llvm/llvm-project/pull/67684
__
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow th
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow th
pogo59 wrote:
Many of the clang-format complaints on this one are from the first commit,
which I wanted to make as minimalist as possible. I believe I didn't make the
file any _less_ conformant in that commit. :) I will fix the others.
https://github.com/llvm/llvm-project/pull/67684
_
https://github.com/erichkeane commented:
This too fails the formatter. That said, I have no comments, though
preprocessing isn't my place of expertise. Most of the changes are pretty mild
though, and the approach of just replacing the output file with a null-OS seems
appropriate. Fix the fo
pogo59 wrote:
Ping @erichkeane were you willing to approve both this and #67613?
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Also added a release note.
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/4] [NFC] Change a reference member to pointer
This will allow th
pogo59 wrote:
> The first link does, somewhat, and seems like the right place to add this new
> option. I'll have a go at that.
Well, that one appears to be generated from the Options.td file, and simply
includes the help text, so in effect I've already done that. :)
UsersManual.html doesn't
pogo59 wrote:
Aha! Thank you. I should have found that third one in my searches, although it
doesn't really describe the options that affect `-E` mode. The first link does,
somewhat, and seems like the right place to add this new option. I'll have a go
at that.
https://github.com/llvm/llvm-pr
jrtc27 wrote:
Oh and https://clang.llvm.org/docs/CommandGuide/clang.html.
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrtc27 wrote:
I mean places like https://clang.llvm.org/docs/ClangCommandLineReference.html
and https://clang.llvm.org/docs/UsersManual.html#command-line-options.
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits
pogo59 wrote:
@jrtc27 I've beefed up the help text some. I'm unable to find any "rendered
documentation" for `-E` and friends; if you can point me to it, I'd be happy to
add the new option there.
https://github.com/llvm/llvm-project/pull/67684
___
cf
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/3] [NFC] Change a reference member to pointer
This will allow th
jrtc27 wrote:
Its limitations, i.e. how in various cases it can break or change correct code,
need to be documented somewhere alongside the option (ideally a disclaimer in
--help's output and a longer explanation in the rendered documentation).
https://github.com/llvm/llvm-project/pull/67684
_
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1b7285bf3ee73975fa63acfc5301a9b57a53fca2
a71131f734c90aeaff9c3fb0cdc57c0f81dd8971 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
This option will cause -E to preserve the #include directives
for system headers, rather than expanding them into the output.
This can greatly reduce the volume of preprocessed source text
in a test case, making test case reduction simpler.
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/67684
This option will cause -E to preserve the #include directives
for system headers, rather than expanding them into the output.
This can greatly reduce the volume of preprocessed source text
in a test case, making t
20 matches
Mail list logo
