Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

2020-10-12 Thread Richard Smith via cfe-commits
Thanks, yes, it looks like we don't properly inherit inheritable attributes in redeclarations of ObjCInterfaceDecls. Fixed in e2d4174e9c66251d1b408234b53f53d0903c0285. Let's try unreverting and see if things look better. On Mon, 12 Oct 2020 at 11:08, Arthur Eubanks wrote: > Could there be an is

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

2020-10-12 Thread Arthur Eubanks via cfe-commits
Could there be an issue with Objective C property attributes? https://crbug.com/1134762 On Sun, Oct 11, 2020 at 2:11 PM Richard Smith wrote: > Please can you try building with https://reviews.llvm.org/D89212 applied > first, and see if it produces any warnings? If so, you're probably hitting > P

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

2020-10-11 Thread Richard Smith via cfe-commits
Please can you try building with https://reviews.llvm.org/D89212 applied first, and see if it produces any warnings? If so, you're probably hitting PR47663, and should fix that by moving the 'weak' attribute earlier. On Sun, 11 Oct 2020 at 11:18, Richard Smith wrote: > On Fri, 9 Oct 2020 at 19:1

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

2020-10-11 Thread Richard Smith via cfe-commits
On Fri, 9 Oct 2020 at 19:12, Arthur Eubanks wrote: > I think this is the cause of https://crbug.com/1134762. Can we > speculatively revert while coming up with a repro? Or would you like a > repro first? > If you're blocked on this, sure, please go ahead and revert until you have a repro. But th

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

2020-10-09 Thread Arthur Eubanks via cfe-commits
I think this is the cause of https://crbug.com/1134762. Can we speculatively revert while coming up with a repro? Or would you like a repro first? On Sun, Sep 27, 2020 at 7:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-09-27T19:05:

[clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

2020-09-27 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-09-27T19:05:26-07:00 New Revision: 9dcd96f728863d40d6f5922ed52732fdd728fb5f URL: https://github.com/llvm/llvm-project/commit/9dcd96f728863d40d6f5922ed52732fdd728fb5f DIFF: https://github.com/llvm/llvm-project/commit/9dcd96f728863d40d6f5922ed52732fdd728fb5f.diff