On Fri, Mar 27, 2020 at 5:16 PM Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 !
>
> David: You are correct, the bug in function_ref appeared only when
> constructing from `const function_ref&&`. When I
On Fri, Mar 27, 2020 at 8:16 PM Arthur O'Dwyer
wrote:
> Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 !
>
> David: You are correct, the bug in function_ref appeared only when
> constructing from `const function_ref&&`. When I said that the constructor
> template suppress
Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 !
David: You are correct, the bug in function_ref appeared only when
constructing from `const function_ref&&`. When I said that the constructor
template suppressed the copy constructor, I was wrong. The implicitly
generated co
On Fri, 27 Mar 2020 at 16:35, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Mar 26, 2020 at 8:49 PM Richard Smith
> wrote:
>
>> On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Thu, Mar 26, 2020 at 3:12 PM
On Thu, 26 Mar 2020 at 21:50, Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Mar 26, 2020 at 11:49 PM Richard Smith
> wrote:
>
>> On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Thu, Mar 26, 2020 at 3:12
On Thu, Mar 26, 2020 at 8:49 PM Richard Smith wrote:
> On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer
>> wrote:
>>
>>> I'm not sure, but I do see that the call stack contains a call to
>>>
>>>
On Thu, Mar 26, 2020 at 11:49 PM Richard Smith
wrote:
> On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer
>> wrote:
>>
>>> I'm not sure, but I do see that the call stack contains a call to
>>>
>>
On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer
> wrote:
>
>> I'm not sure, but I do see that the call stack contains a call to
>>
>> bool llvm::function_ref> bool)>::callback_fn
>> const>(long, cla
On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer
wrote:
> I'm not sure, but I do see that the call stack contains a call to
>
> bool llvm::function_ref bool)>::callback_fn
> const>(long, clang::Expr*&, bool)
>
> Notice that this is function_ref::callback_fn instantiated with
> T=function_ref itsel
I'm not sure, but I do see that the call stack contains a call to
bool llvm::function_ref::callback_fn
const>(long, clang::Expr*&, bool)
Notice that this is function_ref::callback_fn instantiated with
T=function_ref itself; i.e., we do have a function_ref to a function_ref.
This is the thing I wa
Hey Richard - could you help try to diagnose what's happening here?
I reverted this patch in:
https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb
But that did actually cause buildbot failures, such as these ones:
http://lab.llvm.org:8011/builders/clang-ppc64be-linu
Apologies for the confusion.
I wrote the commit message after looking into this and I though the
issue was related to the capture by copy in the inner llvm::any_of and
the reuse in the outer. Looking back at the code I cannot say anymore
how I got that impression.
If you think the reference is
Reverted in 0d0b90105f92f6cd9cc7004d565834f4429183fb & I'll see what
happens with the buildbots.
On Sun, Mar 22, 2020 at 5:47 PM Johannes Doerfert
wrote:
>
> Apologies for the confusion.
>
> I wrote the commit message after looking into this and I though the
> issue was related to the capture by
On Sun, Mar 22, 2020 at 1:48 PM David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Sun, Mar 22, 2020 at 10:40 AM Johannes Doerfert
> wrote:
>
>> Some buildbots, I think only Windows buildbots for some reason, crashed
>> in this function.
>>
>> The reason, as described, is tha
Some buildbots, I think only Windows buildbots for some reason, crashed
in this function.
The reason, as described, is that an `llvm::function_ref` cannot be
copied and then reused. It just happened to work on almost all
configurations.
The change was not a "shot in the dark" but identified
On Sun, Mar 22, 2020 at 10:40 AM Johannes Doerfert
wrote:
> Some buildbots, I think only Windows buildbots for some reason, crashed
> in this function.
>
> The reason, as described, is that an `llvm::function_ref` cannot be
> copied and then reused. It just happened to work on almost all
> config
"a problem" seems a smidge vague - was there a specific explanation for the
kind of problem that was signalled? Or was this fix a bit of a shot in the
dark?
On Sat, Feb 15, 2020 at 10:55 PM Johannes Doerfert via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> Author: Johannes Doerfert
> Date
Author: Johannes Doerfert
Date: 2020-02-16T00:51:11-06:00
New Revision: 857bf5da35af8e1f9425e1865dab5f5fce5e38f2
URL:
https://github.com/llvm/llvm-project/commit/857bf5da35af8e1f9425e1865dab5f5fce5e38f2
DIFF:
https://github.com/llvm/llvm-project/commit/857bf5da35af8e1f9425e1865dab5f5fce5e38f2.d
18 matches
Mail list logo
