Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

2020-10-26 Thread Richard Smith via cfe-commits
Fixed in a5c7b46862ec0531964eb52329cdf009862abecf. On Mon, 26 Oct 2020 at 15:59, Richard Smith wrote: > Reduces to: > > int d; > int &h = d; > double e = h; > > ... but only fails under -fms-compatibility. > > On Mon, 26 Oct 2020 at 13:46, Nico Weber wrote: > >> The original snippet: >> >> co

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

2020-10-26 Thread Richard Smith via cfe-commits
Reduces to: int d; int &h = d; double e = h; ... but only fails under -fms-compatibility. On Mon, 26 Oct 2020 at 13:46, Nico Weber wrote: > The original snippet: > > const int64_t& kGraceMs = > AffiliationFetchThrottler::kGracePeriodAfterReconnectMs; > ASSERT_NO_FATAL_FAILURE(AssertR

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

2020-10-26 Thread Nico Weber via cfe-commits
The original snippet: const int64_t& kGraceMs = AffiliationFetchThrottler::kGracePeriodAfterReconnectMs; ASSERT_NO_FATAL_FAILURE(AssertReleaseInBetween( true, kGraceMs * (1 - kPolicy.jitter_factor), kGraceMs)); kGracePeriod is declared here https://source.chromium.org/chromium/chr

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

2020-10-26 Thread Nico Weber via cfe-commits
Hi Richard, this makes clang assert when building chromium/win. https://bugs.chromium.org/p/chromium/issues/detail?id=1142009#c4 has a reduced repro. Could you take a look? Thanks, Nico On Mon, Oct 19, 2020 at 10:04 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Autho

[clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

2020-10-19 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-19T19:04:04-07:00 New Revision: 76c0092665867a6defcd328ba0d0d976eb65d991 URL: https://github.com/llvm/llvm-project/commit/76c0092665867a6defcd328ba0d0d976eb65d991 DIFF: https://github.com/llvm/llvm-project/commit/76c0092665867a6defcd328ba0d0d976eb65d991.diff