Re: [clang] 4711512 - Fix oversight in AST traversal helper

2020-01-05 Thread Stephen Kelly via cfe-commits
Sorry, will do. This was something I had intended to do in the original commit. Thanks, Stephen. On 05/01/2020 22:00, Aaron Ballman wrote: Can you also include more detail in commit logs than this? It doesn't explain why this is an oversight, which makes code archaeology harder later. On

Re: [clang] 4711512 - Fix oversight in AST traversal helper

2020-01-05 Thread Aaron Ballman via cfe-commits
Can you also include more detail in commit logs than this? It doesn't explain why this is an oversight, which makes code archaeology harder later. On Sun, Jan 5, 2020, 3:32 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2020-01-05T20:27:37Z

Re: [clang] 4711512 - Fix oversight in AST traversal helper

2020-01-05 Thread Stephen Kelly via cfe-commits
Added in 35efef5351e. Thanks, Stephen. On 05/01/2020 20:33, Roman Lebedev wrote: Is there a test for this missing? On Sun, Jan 5, 2020 at 11:32 PM Stephen Kelly via cfe-commits wrote: Author: Stephen Kelly Date: 2020-01-05T20:27:37Z New Revision: 471151238438201f3fe365a7784f1a091328e46c

Re: [clang] 4711512 - Fix oversight in AST traversal helper

2020-01-05 Thread Roman Lebedev via cfe-commits
Is there a test for this missing? On Sun, Jan 5, 2020 at 11:32 PM Stephen Kelly via cfe-commits wrote: > > > Author: Stephen Kelly > Date: 2020-01-05T20:27:37Z > New Revision: 471151238438201f3fe365a7784f1a091328e46c > > URL: > https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7

[clang] 4711512 - Fix oversight in AST traversal helper

2020-01-05 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2020-01-05T20:27:37Z New Revision: 471151238438201f3fe365a7784f1a091328e46c URL: https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c DIFF: https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c.diff LOG: