On Thu, Oct 28, 2021 at 9:55 AM Nico Weber wrote:
>
> On Mon, Oct 25, 2021 at 9:06 PM Nico Weber wrote:
>>
>> Looks like the reason for this check was that
>> https://github.com/llvm/llvm-project/blob/3b42fc8a07c37e47efae80c931eff7e63103e0e9/clang/include/clang/Basic/Attr.td#L1946
>> contains _
On Mon, Oct 25, 2021 at 9:06 PM Nico Weber wrote:
> Looks like the reason for this check was that
> https://github.com/llvm/llvm-project/blob/3b42fc8a07c37e47efae80c931eff7e63103e0e9/clang/include/clang/Basic/Attr.td#L1946
> contains __unsafe_unretained despite it just being a macro here:
> http:
On Mon, Oct 25, 2021 at 8:41 PM Nico Weber wrote:
>
> Was this reviewed anywhere?
Post-commit review (as attribute code owner).
> I'll note that some internal project apparently used to check `#if
> __has_attribute(__unsafe_unretained)`. That used to silently (and incorrectly
> I think) always
Looks like the reason for this check was that
https://github.com/llvm/llvm-project/blob/3b42fc8a07c37e47efae80c931eff7e63103e0e9/clang/include/clang/Basic/Attr.td#L1946
contains __unsafe_unretained despite it just being a macro here:
http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/InitPreprocesso
Was this reviewed anywhere?
I'll note that some internal project apparently used to check `#if
__has_attribute(__unsafe_unretained)`. That used to silently (and
incorrectly I think) always return 0 as far as I can tell, but now it fails
with:
```
$ out/gn/bin/clang -c foo.mm
foo.mm:1:21: error: m
On Mon, Oct 18, 2021 at 4:13 PM Richard Smith wrote:
>
> On Mon, 18 Oct 2021 at 12:56, Aaron Ballman wrote:
>>
>> On Mon, Oct 18, 2021 at 3:52 PM Richard Smith wrote:
>> >
>> > On Mon, 18 Oct 2021 at 12:48, Aaron Ballman
>> > wrote:
>> >>
>> >> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith
On Mon, 18 Oct 2021 at 12:56, Aaron Ballman wrote:
> On Mon, Oct 18, 2021 at 3:52 PM Richard Smith
> wrote:
> >
> > On Mon, 18 Oct 2021 at 12:48, Aaron Ballman
> wrote:
> >>
> >> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith
> wrote:
> >> >
> >> > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman v
On Mon, Oct 18, 2021 at 3:52 PM Richard Smith wrote:
>
> On Mon, 18 Oct 2021 at 12:48, Aaron Ballman wrote:
>>
>> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith wrote:
>> >
>> > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits
>> > wrote:
>> >>
>> >>
>> >> Author: Aaron Ballman
>> >
On Mon, 18 Oct 2021 at 12:48, Aaron Ballman wrote:
> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith
> wrote:
> >
> > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >>
> >>
> >> Author: Aaron Ballman
> >> Date: 2021-10-17T07:54:48-04:00
> >> N
On Mon, Oct 18, 2021 at 3:33 PM Richard Smith wrote:
>
> On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits
> wrote:
>>
>>
>> Author: Aaron Ballman
>> Date: 2021-10-17T07:54:48-04:00
>> New Revision: 2edb89c746848c52964537268bf03e7906bf2542
>>
>> URL:
>> https://github.com/llvm/llvm-pr
On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> Author: Aaron Ballman
> Date: 2021-10-17T07:54:48-04:00
> New Revision: 2edb89c746848c52964537268bf03e7906bf2542
>
> URL:
> https://github.com/llvm/llvm-project/commit/2edb89c746848c52964537268bf03
Author: Aaron Ballman
Date: 2021-10-17T07:54:48-04:00
New Revision: 2edb89c746848c52964537268bf03e7906bf2542
URL:
https://github.com/llvm/llvm-project/commit/2edb89c746848c52964537268bf03e7906bf2542
DIFF:
https://github.com/llvm/llvm-project/commit/2edb89c746848c52964537268bf03e7906bf2542.diff
12 matches
Mail list logo
