https://github.com/redstar closed
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xnox wrote:
Requiring a config file when previously was not needed is a regression in
behaviour for distributions.
I guess Ubuntu would have to continue to patch this back in.
Built-in defaults exist for a reason and yes at times need to be higher.
This change risks performance regressions fo
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4141,6 +4141,20 @@
// Begin SystemZ/GCC/Linux tests
+// RUN: %clang -E -dM %s -o - 2>&1 \
+// RUN: -target s390x-ibm-zos \
MaskRay wrote:
`--target=` for new driver tests.
However, this does not test clangDriver and therefore `%clan
MaskRay wrote:
> @FHe
>
> > > > @MaskRay Got it.
> > > > The problem with that solution is that if you use --target you won't
> > > > get the correct arch. This would be a problem for any cross
> > > > compilation. For example, say you cross compile from zLinux (which
> > > > wouldn't have th
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/4] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
perry-ca wrote:
I removed the additional use of CLANG_SYSTEMZ_DEFAULT_ARCH and left that for a
separate discussion. The only code clean up left here is the elimination of
the `CPU` member that wasn't used.
https://github.com/llvm/llvm-project/pull/89854
___
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2ace7bdcfe640c69bd4dcf508d39485e0ef7ea06
fe5ad9c1bc0b1c0d60451f017d7ec7a8233aaf26 --
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/3] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
xnox wrote:
@fhe
> > > @MaskRay Got it.
> > > The problem with that solution is that if you use --target you won't get
> > > the correct arch. This would be a problem for any cross compilation. For
> > > example, say you cross compile from zLinux (which wouldn't have the
> > > config file), t
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/2] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
MaskRay wrote:
> > @MaskRay Got it.
> > The problem with that solution is that if you use --target you won't get
> > the correct arch. This would be a problem for any cross compilation. For
> > example, say you cross compile from zLinux (which wouldn't have the config
> > file), the arch would
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
That was my preference too except clang/Config/config.h has a clause that it
can only be included once an
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
MaskRay wrote:
If SystemZ.h uses CLANG_SYSTEMZ_DEFAULT_ARCH, that file should have `#include
"clang/Config/config.h"` as
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
This is needed for the change in SystemZ.h to replace the hard coded `"z10"`
string with the CLANG_SYSTEM
@@ -10,6 +10,8 @@
//
//===--===//
+#include "clang/Config/config.h"
MaskRay wrote:
unneeded include
https://github.com/llvm/llvm-project/pull/89854
_
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
MaskRay wrote:
unneeded include
https://github.com/llvm/llvm-project/pull/89854
_
perry-ca wrote:
@MaskRay no worries. This brittle test issue was a reason I trying to keep the
default for zLinux unchanged by this.
I have posted a new commit that eliminates the cmake variable for z/OS.
https://github.com/llvm/llvm-project/pull/89854
MaskRay wrote:
> @MaskRay Got it.
>
> The problem with that solution is that if you use --target you won't get the
> correct arch. This would be a problem for any cross compilation. For example,
> say you cross compile from zLinux (which wouldn't have the config file), the
> arch would be arc
perry-ca wrote:
I removed the ability to make z/OS default arch configurable at build time. We
don't really need it and this makes the code simpler.
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/2] Set the default arch for z/OS to be arch10
---
clang/CMakeLis
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH] Set the default arch for z/OS to be arch10
---
clang/CMakeLists.t
perry-ca wrote:
ping @MaskRay ^^^
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
@MaskRay Got it.
The problem with that solution is that if you use --target you won't get the
correct arch. This would be a problem for any cross compilation. For example,
say you cross compile from zLinux (which wouldn't have the config file), the
arch would be arch8. A
MaskRay wrote:
Clang configuration files
https://clang.llvm.org/docs/UsersManual.html#configuration-files cover your use
case and the feature is exactly designed to avoid such cmake default configs.
https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-config
perry-ca wrote:
ping @MaskRay. Thanks
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
27 matches
Mail list logo
