https://github.com/atetubou updated
https://github.com/llvm/llvm-project/pull/83961
>From 6e2521733cdc49971529977cb81c731dd2816b42 Mon Sep 17 00:00:00 2001
From: Takuto Ikuta
Date: Mon, 18 Mar 2024 18:03:00 +0900
Subject: [PATCH 1/2] git squash commit for support_new_trace.
90ebde07f7fa426a37d
ZequanWu wrote:
> > > > IIUC, the approach you choose here is to let `SemaPPCallbacks` control
> > > > the "entered file stack" and allow it to remove element (which is file)
> > > > from middle of the internal stack in `TimeTraceProfiler`, but this
> > > > creates async event which is not des
atetubou wrote:
> > > IIUC, the approach you choose here is to let `SemaPPCallbacks` control
> > > the "entered file stack" and allow it to remove element (which is file)
> > > from middle of the internal stack in `TimeTraceProfiler`, but this
> > > creates async event which is not designed fo
@@ -102,23 +104,24 @@ struct llvm::TimeTraceProfiler {
llvm::get_thread_name(ThreadName);
}
- void begin(std::string Name, llvm::function_ref Detail) {
-Stack.emplace_back(ClockType::now(), TimePointType(), std::move(Name),
- Detail());
+ Time
ZequanWu wrote:
> > IIUC, the approach you choose here is to let `SemaPPCallbacks` control the
> > "entered file stack" and allow it to remove element (which is file) from
> > middle of the internal stack in `TimeTraceProfiler`, but this creates async
> > event which is not designed for this p
@@ -102,23 +104,24 @@ struct llvm::TimeTraceProfiler {
llvm::get_thread_name(ThreadName);
}
- void begin(std::string Name, llvm::function_ref Detail) {
-Stack.emplace_back(ClockType::now(), TimePointType(), std::move(Name),
- Detail());
+ Time
@@ -102,23 +104,24 @@ struct llvm::TimeTraceProfiler {
llvm::get_thread_name(ThreadName);
}
- void begin(std::string Name, llvm::function_ref Detail) {
-Stack.emplace_back(ClockType::now(), TimePointType(), std::move(Name),
- Detail());
+ Time
atetubou wrote:
> IIUC, the approach you choose here is to let `SemaPPCallbacks` control the
> "entered file stack" and allow it to remove element (which is file) from
> middle of the internal stack in `TimeTraceProfiler`, but this creates async
> event which is not designed for this purpose.
https://github.com/atetubou updated
https://github.com/llvm/llvm-project/pull/83961
>From 90ebde07f7fa426a37dd4bdc362e1a809aaf0844 Mon Sep 17 00:00:00 2001
From: Takuto Ikuta
Date: Mon, 4 Mar 2024 19:12:31 +0900
Subject: [PATCH 1/3] Expose TimeTraceProfiler for Async Events
---
llvm/include/l
@@ -132,15 +135,18 @@ struct llvm::TimeTraceProfiler {
// happens to be the ones that don't have any currently open entries above
// itself.
if (llvm::none_of(llvm::drop_begin(llvm::reverse(Stack)),
- [&](const TimeTraceProfilerEntry &Val) {
-
https://github.com/ZequanWu commented:
IIUC, the approach you choose here is to let `SemaPPCallbacks` control the
"entered file stack" and allow it to remove element (which is file) from middle
of the internal stack in `TimeTraceProfiler`, but this creates async event
which is not designed for
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/83961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -102,23 +104,24 @@ struct llvm::TimeTraceProfiler {
llvm::get_thread_name(ThreadName);
}
- void begin(std::string Name, llvm::function_ref Detail) {
-Stack.emplace_back(ClockType::now(), TimePointType(), std::move(Name),
- Detail());
+ Time
atetubou wrote:
@ZequanWu could you take a look this?
https://github.com/llvm/llvm-project/pull/83961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Author: Takuto Ikuta (atetubou)
Changes
This fixes incorrect trace for
https://github.com/llvm/llvm-project/issues/56554.
This shows trace like
https://ui.perfetto.dev/#!/?s=aa809778dc50f2b155b062317fa18bbe2bb2fb9175e6282add8121c7c178214e
https://github.com/atetubou ready_for_review
https://github.com/llvm/llvm-project/pull/83961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/atetubou edited
https://github.com/llvm/llvm-project/pull/83961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
17 matches
Mail list logo
