AaronBallman wrote:
> Okay, thanks for clarifying. Shall I close this one?
I don't see a lot of value in the change, but because it's an NFC and the
changes only impact code always compiled as C++ anyway, it's not entirely
unreasonable. Personally, I'd close, but it's up to you (if you move ah
vgvassilev wrote:
Okay, thanks for clarifying. Shall I close this one?
https://github.com/llvm/llvm-project/pull/108529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> If the implementation is conforming this doesn't do anything. In fact, they
> have to be the same function.
That was my understanding as well, thanks! So it sounds like the problem is
that there's an underlying `::getenv` that isn't thread safe (which is
conforming accor
philnik777 wrote:
If the implementation is conforming this doesn't do anything. In fact, they
have to be the same function.
https://github.com/llvm/llvm-project/pull/108529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
vgvassilev wrote:
> > > Are we sure this is going to do what we think?
> > > https://github.com/llvm/llvm-project/blob/a41bb71f2216cef08ab04f1d730ae1701c145f3c/libcxx/include/cstdlib#L127
> > >
> > > https://github.com/gcc-mirror/gcc/blob/494d3c3faaee0dbde696ea334f8e242ae85ae2b5/libstdc%2B%2B-v3
AaronBallman wrote:
> > Are we sure this is going to do what we think?
> > https://github.com/llvm/llvm-project/blob/a41bb71f2216cef08ab04f1d730ae1701c145f3c/libcxx/include/cstdlib#L127
> >
> > https://github.com/gcc-mirror/gcc/blob/494d3c3faaee0dbde696ea334f8e242ae85ae2b5/libstdc%2B%2B-v3/inclu
vgvassilev wrote:
> Are we sure this is going to do what we think?
>
> https://github.com/llvm/llvm-project/blob/a41bb71f2216cef08ab04f1d730ae1701c145f3c/libcxx/include/cstdlib#L127
>
> https://github.com/gcc-mirror/gcc/blob/494d3c3faaee0dbde696ea334f8e242ae85ae2b5/libstdc%2B%2B-v3/include/c_co
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
@llvm/pr-subscribers-clang-driver
Author: Vassil Vassilev (vgvassilev)
Changes
Posix call to ::getenv is not guarenteed to be thread safe while C++11 made
std::getenv thread safe.
This resolves bugs when using llvm in multithreaded environ
https://github.com/vgvassilev created
https://github.com/llvm/llvm-project/pull/108529
Posix call to ::getenv is not guarenteed to be thread safe while C++11 made
std::getenv thread safe.
This resolves bugs when using llvm in multithreaded environment similar to
cms-sw/cmssw#44659
>From 4ae2
